Skip to content
Merged
Show file tree
Hide file tree
Changes from 39 commits
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
e9212ce
Replace brittle waits with deterministic polling
ikostan Jul 24, 2026
c001cc5
style: format code with Black and isort
deepsource-autofix[bot] Jul 24, 2026
3a0d209
Update audio_flow_test.py
ikostan Jul 24, 2026
a8ad61c
Update audio_flow_test.py
ikostan Jul 24, 2026
b6ae1a2
Update audio_flow_test.py
ikostan Jul 24, 2026
5383d27
Update audio_flow_test.py
ikostan Jul 24, 2026
3249cba
Update audio_flow_test.py
ikostan Jul 24, 2026
ba105a1
style: format code with Black and isort
deepsource-autofix[bot] Jul 24, 2026
1ed1d52
Format tests/back_flow_test.py for readability
ikostan Jul 24, 2026
80fa9b4
Format long lines in conftest.py
ikostan Jul 24, 2026
fc5c223
Format difficulty_flow_test.py for readability
ikostan Jul 24, 2026
619f751
Format test file for line length compliance
ikostan Jul 24, 2026
e970ddc
Add SFX slider state validation in reset test
ikostan Jul 24, 2026
70fcb18
Update difficulty_flow_test.py
ikostan Jul 24, 2026
bbb9641
Update reset_audio_flow_test.py
ikostan Jul 24, 2026
a6bf920
style: format code with Black and isort
deepsource-autofix[bot] Jul 24, 2026
0d93748
Refactor navigation_to_audio_test for readability
ikostan Jul 25, 2026
3885a33
style: format code with Black and isort
deepsource-autofix[bot] Jul 25, 2026
4dfc7df
Update no_error_logs_test.py
ikostan Jul 25, 2026
14f61ec
Merge branch 'code-audits-asynchronous-refactoring' of https://github…
ikostan Jul 25, 2026
e45bf81
Update volume_sliders_mutes_test.py
ikostan Jul 25, 2026
08a9d95
style: format code with Black and isort
deepsource-autofix[bot] Jul 25, 2026
d7b39cb
Extract shared test utilities to test_utils module
ikostan Jul 25, 2026
12a1ef3
Refactor test files: fix wait_for_console_log signature
ikostan Jul 25, 2026
131bfd9
Merge branch 'code-audits-asynchronous-refactoring' of https://github…
ikostan Jul 25, 2026
7c9cb51
style: format code with Black and isort
deepsource-autofix[bot] Jul 25, 2026
a3eb045
Update test_utils.py
ikostan Jul 25, 2026
fbdb78d
Merge branch 'code-audits-asynchronous-refactoring' of https://github…
ikostan Jul 25, 2026
d35b9a7
Remove unused pytest imports in tests
ikostan Jul 25, 2026
dfd6770
Update test_utils.py
ikostan Jul 25, 2026
3ba2027
Update audio_flow_test.py
ikostan Jul 26, 2026
f5b42af
Update workspace/run_browser_tests.sh
ikostan Jul 26, 2026
baba299
Update workspace/run_browser_tests.sh
ikostan Jul 26, 2026
973c3cf
Update reset_audio_flow_test.py
ikostan Jul 26, 2026
ed03414
Update test_utils.py
ikostan Jul 26, 2026
3814f97
Centralized `has_save_log`
ikostan Jul 26, 2026
095e22f
Update test_utils.py
ikostan Jul 26, 2026
8118c1d
Add console log wait for save/encrypt operations
ikostan Jul 26, 2026
04027dc
style: format code with Black and isort
deepsource-autofix[bot] Jul 26, 2026
c5f3707
Update audio_flow_test.py
ikostan Jul 26, 2026
64e0781
Create Part_2_Replace_brittle_waits_with_deterministic_polling.md
ikostan Jul 26, 2026
e0ba179
Merge branch 'code-audits-asynchronous-refactoring' of https://github…
ikostan Jul 26, 2026
05d3c9d
Update volume_sliders_mutes_test.py
ikostan Jul 26, 2026
78098c2
Update Part_2_Replace_brittle_waits_with_deterministic_polling.md
ikostan Jul 26, 2026
2a83e2f
Update Part_2_Replace_brittle_waits_with_deterministic_polling.md
ikostan Jul 26, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
248 changes: 127 additions & 121 deletions tests/audio_flow_test.py

Large diffs are not rendered by default.

210 changes: 127 additions & 83 deletions tests/back_flow_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@

Overview
--------
E2E tests for BACK-01 to BACK-04: Validate back button behavior from audio menu, including return to options, no state mutation without changes, persistence of changes, and handling mid-interaction.
E2E tests for BACK-01 to BACK-04: Validate back button behavior from audio menu,
including return to options, no state mutation without changes, persistence of changes,
and handling mid-interaction.

Navigates to audio menu, performs actions, backs out, verifies states/logs.

Expand All @@ -28,20 +30,18 @@
import json
import os
import time
from typing import Any

from playwright.sync_api import Page
from playwright.sync_api import Page, expect

# Configuration for stability in different environments
# Default to 5000ms, but allow CI to override via environment variable
DEFAULT_TIMEOUT = int(os.getenv("TEST_TIMEOUT", "30000"))
TEST_TIMEOUT = int(os.getenv("TEST_TIMEOUT", "10000"))
from tests.test_utils import DEFAULT_TIMEOUT, TEST_TIMEOUT, wait_for_console_log


def test_back_flow(page: Page) -> None:
"""
Main test suite for back navigation using DOM overlays.

Implements BACK-01 to BACK-04: Back from audio, verify return, state persistence, no exceptions.
Implements BACK-01 to BACK-04: Back from audio, verify return, state persistence.

:param page: The Playwright page object.
:type page: Page
Expand All @@ -50,7 +50,7 @@ def test_back_flow(page: Page) -> None:
logs: list[dict[str, str]] = []
cdp_session = None

def on_console(msg) -> None:
def on_console(msg: Any) -> None:
"""
Console message handler to capture logs.

Expand All @@ -61,8 +61,9 @@ def on_console(msg) -> None:
logs.append({"type": msg.type, "text": msg.text})

page.on("console", on_console)

try:
# Start CDP session for V8 JS coverage (workaround for Python Playwright lacking native coverage API)
# Start CDP session for V8 JS coverage
cdp_session = page.context.new_cdp_session(page)
cdp_session.send("Profiler.enable")
cdp_session.send(
Expand All @@ -74,21 +75,23 @@ def on_console(msg) -> None:
wait_until="networkidle",
timeout=DEFAULT_TIMEOUT,
)
# 1. Wait for the engine to actually start the splash scene
page.wait_for_timeout(TEST_TIMEOUT)
page.wait_for_function("() => window.godotInitialized", timeout=DEFAULT_TIMEOUT)
# 1. Wait deterministically for Godot engine initialization
page.wait_for_function(
"() => window.godotInitialized === true", timeout=DEFAULT_TIMEOUT
)

# Verify canvas
canvas = page.locator("canvas")
page.wait_for_selector("canvas", state="visible", timeout=DEFAULT_TIMEOUT)
expect(canvas).to_be_visible(timeout=DEFAULT_TIMEOUT)
box: dict[str, float] | None = canvas.bounding_box()
assert box is not None, "Canvas not found"
assert "SkyLockAssault" in page.title(), "Title not found"

# Navigate to options menu
page.wait_for_selector("#options-button", state="visible", timeout=TEST_TIMEOUT)
page.wait_for_function(
"window.optionsPressed !== undefined", timeout=TEST_TIMEOUT
"() => typeof window.optionsPressed !== 'undefined'",
timeout=TEST_TIMEOUT,
)
page.evaluate("window.optionsPressed([])")

Expand All @@ -97,26 +100,29 @@ def on_console(msg) -> None:
"#advanced-button", state="visible", timeout=TEST_TIMEOUT
)
page.wait_for_function(
"window.advancedPressed !== undefined", timeout=TEST_TIMEOUT
"() => typeof window.advancedPressed !== 'undefined'",
timeout=TEST_TIMEOUT,
)
page.evaluate("window.advancedPressed([])")
page.wait_for_function(
"window.changeLogLevel !== undefined", timeout=TEST_TIMEOUT
"() => typeof window.changeLogLevel !== 'undefined'",
timeout=TEST_TIMEOUT,
)
advanced_display: str = page.evaluate(
"window.getComputedStyle(document.getElementById('log-level-select')).display"
page.wait_for_function(
"() => window.getComputedStyle("
"document.getElementById('log-level-select')"
").display === 'block'",
timeout=TEST_TIMEOUT,
)
assert (
advanced_display == "block"
), "Advanced menu not loaded (selected log level not displayed)"

# Set log level DEBUG
pre_change_log_count = len(logs)
page.evaluate("window.changeLogLevel([0])")
page.wait_for_timeout(TEST_TIMEOUT)
new_logs = logs[pre_change_log_count:]
assert any(
"log level changed to: debug" in log["text"].lower() for log in new_logs
wait_for_console_log(
logs,
lambda text: "log level changed to: debug" in text,
pre_change_log_count,
page,
)
assert page.evaluate(
"document.getElementById('audio-button') !== null"
Expand All @@ -127,143 +133,181 @@ def on_console(msg) -> None:
"#advanced-back-button", state="visible", timeout=TEST_TIMEOUT
)
page.wait_for_function(
"window.advancedBackPressed !== undefined", timeout=TEST_TIMEOUT
"() => typeof window.advancedBackPressed !== 'undefined'",
timeout=TEST_TIMEOUT,
)
page.evaluate("window.advancedBackPressed([])")

# Navigate to audio sub-menu
page.wait_for_selector("#audio-button", state="visible", timeout=TEST_TIMEOUT)
assert page.evaluate(
"document.getElementById('audio-button') !== null"
), "Audio button not found/displayed"
pre_change_log_count = len(logs)
page.wait_for_function(
"window.audioPressed !== undefined", timeout=TEST_TIMEOUT
"() => typeof window.audioPressed !== 'undefined'",
timeout=TEST_TIMEOUT,
)
page.evaluate("window.audioPressed([])")
page.wait_for_timeout(TEST_TIMEOUT) # Wait for audio scene load and JS eval
audio_display: str = page.evaluate(
"window.getComputedStyle(document.getElementById('master-slider')).display"

# Wait deterministically for audio menu display
page.wait_for_function(
"() => window.getComputedStyle("
"document.getElementById('master-slider')"
").display === 'block'",
timeout=TEST_TIMEOUT,
)
wait_for_console_log(
logs,
lambda text: "audio button pressed." in text,
pre_change_log_count,
page,
)
assert (
audio_display == "block"
), "Audio menu not loaded (master-slider not displayed)"
new_logs = logs[pre_change_log_count:]
assert any(
"audio button pressed." in log["text"].lower() for log in new_logs
), "Audio navigation log not found"

# BACK-01: Back returns to parent menu
# Preconditions: In Audio Settings
# Steps: Press Back
# Expected: Options menu visible
pre_change_log_count = len(logs)
page.wait_for_function(
"window.audioBackPressed !== undefined", timeout=TEST_TIMEOUT
"() => typeof window.audioBackPressed !== 'undefined'",
timeout=TEST_TIMEOUT,
)
page.evaluate("window.audioBackPressed([])")
page.wait_for_timeout(TEST_TIMEOUT)
options_display: str = page.evaluate(
"window.getComputedStyle(document.getElementById('gameplay-button')).display"

page.wait_for_function(
"() => window.getComputedStyle("
"document.getElementById('gameplay-button')"
").display === 'block'",
timeout=TEST_TIMEOUT,
)
page.wait_for_function(
"() => window.getComputedStyle("
"document.getElementById('master-slider')"
").display === 'none'",
timeout=TEST_TIMEOUT,
)
assert options_display == "block", "Did not return to options menu"
audio_display_after: str = page.evaluate(
"window.getComputedStyle(document.getElementById('master-slider')).display"
wait_for_console_log(
logs,
lambda text: "audio settings: back button pressed" in text,
pre_change_log_count,
page,
)
assert audio_display_after == "none", "Audio menu still visible after back"
new_logs = logs[pre_change_log_count:]
assert any(
"audio settings: back button pressed" in log["text"].lower()
for log in new_logs
), "Back log not found"

# Re-enter audio for next tests
page.wait_for_selector("#audio-button", state="visible", timeout=TEST_TIMEOUT)
page.wait_for_function(
"window.audioPressed !== undefined", timeout=TEST_TIMEOUT
"() => typeof window.audioPressed !== 'undefined'",
timeout=TEST_TIMEOUT,
)
page.evaluate("window.audioPressed([0])")
page.wait_for_timeout(TEST_TIMEOUT)
page.wait_for_function(
"() => window.getComputedStyle("
"document.getElementById('master-slider')"
").display === 'block'",
timeout=TEST_TIMEOUT,
)

# BACK-02: Back without changes
# Preconditions: No modification
# Steps: Press Back
# Expected: Back to Options; no state mutation
initial_master: str = page.evaluate(
"document.getElementById('master-slider').value"
)
page.wait_for_function(
"window.audioBackPressed !== undefined", timeout=TEST_TIMEOUT
"() => typeof window.audioBackPressed !== 'undefined'",
timeout=TEST_TIMEOUT,
)
page.evaluate("window.audioBackPressed([])")
page.wait_for_selector("#audio-button", state="visible", timeout=TEST_TIMEOUT)
page.wait_for_function(
"window.audioPressed !== undefined", timeout=TEST_TIMEOUT
"() => typeof window.audioPressed !== 'undefined'",
timeout=TEST_TIMEOUT,
)
page.evaluate("window.audioPressed([0])")
page.wait_for_timeout(TEST_TIMEOUT)
page.wait_for_function(
"() => window.getComputedStyle("
"document.getElementById('master-slider')"
").display === 'block'",
timeout=TEST_TIMEOUT,
)
assert (
page.evaluate("document.getElementById('master-slider').value")
== initial_master
), "State mutated without changes"

# Re-enter audio
page.reload()
page.wait_for_timeout(DEFAULT_TIMEOUT)
page.wait_for_function("() => window.godotInitialized", timeout=TEST_TIMEOUT)
# Re-enter audio via page reload
page.reload(wait_until="networkidle")
page.wait_for_function(
"() => window.godotInitialized === true", timeout=DEFAULT_TIMEOUT
)

# Navigate to options menu
page.wait_for_selector("#options-button", state="visible", timeout=TEST_TIMEOUT)
page.wait_for_function(
"window.optionsPressed !== undefined", timeout=TEST_TIMEOUT
"() => typeof window.optionsPressed !== 'undefined'",
timeout=TEST_TIMEOUT,
)
page.evaluate("window.optionsPressed([])")

# Navigate to audio menu
page.wait_for_selector("#audio-button", state="visible", timeout=TEST_TIMEOUT)
page.wait_for_function(
"window.audioPressed !== undefined", timeout=TEST_TIMEOUT
"() => typeof window.audioPressed !== 'undefined'",
timeout=TEST_TIMEOUT,
)
page.evaluate("window.audioPressed([0])")
page.wait_for_timeout(TEST_TIMEOUT)
page.wait_for_function(
"() => window.getComputedStyle("
"document.getElementById('master-slider')"
").display === 'block'",
timeout=TEST_TIMEOUT,
)

# BACK-03: Back after slider changes
# Preconditions: Sliders adjusted but not Reset
# Steps: Press Back
# Expected: Return; previous changes persist until Reset
page.wait_for_function(
"window.changeMusicVolume !== undefined", timeout=TEST_TIMEOUT
"() => typeof window.changeMusicVolume !== 'undefined'",
timeout=TEST_TIMEOUT,
)
page.evaluate("window.changeMusicVolume([0.4])")
page.wait_for_timeout(TEST_TIMEOUT)
page.wait_for_function(
"window.audioBackPressed !== undefined", timeout=TEST_TIMEOUT
"() => document.getElementById('music-slider').value === '0.4'",
timeout=TEST_TIMEOUT,
)
page.wait_for_function(
"() => typeof window.audioBackPressed !== 'undefined'",
timeout=TEST_TIMEOUT,
)
page.evaluate("window.audioBackPressed([])")
page.wait_for_selector("#audio-button", state="visible", timeout=TEST_TIMEOUT)
page.wait_for_function(
"window.audioPressed !== undefined", timeout=TEST_TIMEOUT
"() => typeof window.audioPressed !== 'undefined'",
timeout=TEST_TIMEOUT,
)
page.evaluate("window.audioPressed([0])")
page.wait_for_timeout(TEST_TIMEOUT)
page.wait_for_function(
"() => window.getComputedStyle("
"document.getElementById('master-slider')"
").display === 'block'",
timeout=TEST_TIMEOUT,
)
assert (
page.evaluate("document.getElementById('music-slider').value") == "0.4"
), "Changes did not persist after back"

# BACK-04: Back from mid-interaction
# Preconditions: Slider being dragged
# Steps: Trigger Back
# Expected: Navigation ok, no JS exceptions
# Simulate mid-drag by setting value without full change event, then back
pre_change_log_count = len(logs)
page.evaluate("""
const slider = document.getElementById('sfx-slider');
slider.value = 0.6;
slider.dispatchEvent(new Event('input')); // Mid-drag
""")
page.wait_for_timeout(TEST_TIMEOUT)
page.wait_for_function(
"window.audioBackPressed !== undefined", timeout=TEST_TIMEOUT
"() => typeof window.audioBackPressed !== 'undefined'",
timeout=TEST_TIMEOUT,
)
page.evaluate("window.audioBackPressed([])")
page.wait_for_timeout(TEST_TIMEOUT)
page.wait_for_function(
"() => window.getComputedStyle("
"document.getElementById('gameplay-button')"
").display === 'block'",
timeout=TEST_TIMEOUT,
)
new_logs = logs[pre_change_log_count:]
assert not any(
"error" in log["text"].lower() for log in new_logs
Expand Down
Loading
Loading