Repository navigation
Merge from master #577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merge from master #577
Changes from all commits
Commits
Show all changes
60 commits
Select commit
Hold shift + click to select a range
6c8427d
[FEATURE] Implement Parallax Scrolling Background linked to Player Sp…
ikostan 1246521
Update main_scene.gd
ikostan b137b63
Update scripts/main_scene.gd
ikostan e436db6
Update main_scene.gd
ikostan e3a9b70
Update main_scene.gd
ikostan 7040237
Here is a comprehensive GUT unit test suite for the new parallax_mana…
ikostan d6b27ed
Update parallax_manager.gd
ikostan 64b1bbc
completely eliminate the _process polling by using Dependency Inject…
ikostan 1dbb09d
Missing coverage for the fuel-depletion reset, and tests implicitly d…
ikostan 6af4227
Update test/gut/test_parallax_manager.gd
ikostan d5cc59a
Update main_scene.gd
ikostan 39bd963
Update parallax_manager.gd
ikostan ee92636
Update main_scene.gd
ikostan 43ed4c2
Update main_scene.gd
ikostan f6eeb1f
Update main_scene.gd
ikostan 19467a2
scroll_offset.y grows unboundedly — consider wrapping to preserve flo…
ikostan bc0702e
Update main_scene.gd
ikostan b101d71
Update parallax_manager.gd
ikostan 9abb76a
126-148: Nit: test name/assertion message is slightly misleading.
ikostan 2c99f7c
63-67: LGTM — refuel recovery path is correctly wired.
ikostan 27a0903
Update main_scene.gd
ikostan 0117f9f
Update parallax_manager.gd
ikostan 87efef1
Update main_scene.gd
ikostan 189ec21
Update main_scene.gd
ikostan 14084a0
This fully resolves the reviewer's concern by creating a proper, publ…
ikostan b7d5b25
let the ParallaxManager inspect its own children and calculate the ma…
ikostan ba0fb22
player's speed is now rigorously typed
ikostan cafaa32
Unit test updates
ikostan a8a50fe
Update test/gut/test_parallax_manager.gd
ikostan 539986c
Update GUT unit tests
ikostan e1c8628
Merge branch 'implement-parallax-scrolling-background-linked-to-playe…
ikostan de072dc
auto_calculate_wrap_period() silently disables wrap when no layers ar…
ikostan d08fb80
Update parallax_manager.gd
ikostan cac27df
Optional: max-of-periods is only safe when layer periods are commens…
ikostan 5fdc662
Update scripts/main_scene.gd
ikostan 4c3c8ec
Update main_scene.gd
ikostan e6cfa37
Update parallax_manager.gd
ikostan 5c46405
Merge pull request #574 from ikostan/implement-parallax-scrolling-bac…
ikostan 90f2b82
Update .gitignore
ikostan 85d572e
Update .gitignore
ikostan 0365ec9
Update run_pipeline.sh
ikostan 371d6bc
README updates
ikostan c3b3b09
Update run_pipeline.sh
ikostan 25e21bf
Update run_gdunit4_unit_tests.sh
ikostan aff443f
Refactor Phase 3: Migrate Core and Manager scripts #526
ikostan 1995f5a
Install GUT before running it and use the configured test directory.
ikostan f9e5307
Refactor Phase 3: Migrate Core and Manager scripts #526
ikostan 9364109
1. Invalid RUN keyword (Line 54) — Dockerfile syntax in a bash script
ikostan 464db5c
2. -gdir=res://test -ginclude_subdirs=true still present (Line 62)
ikostan 49fa33c
Update test_audio_manager.gd
ikostan bb19177
Update run_pipeline.sh
ikostan ea06ea7
install the tool during the Docker build stage so it is "baked in" to…
ikostan 171e27d
Update run_pipeline.sh
ikostan 67535c9
Update run_pipeline.sh
ikostan 41c04bc
Remove or wire PW_TIMEOUT into the pytest command.
ikostan c8e2cc6
Update Platforms_for_Web_Deployment_Guide.md
ikostan 983955a
Update Platforms_for_Web_Deployment_Guide.md
ikostan 8228fbd
issue (bug_risk): Clarify timeout units to match pytest-timeout expec…
ikostan 0aa098b
suggestion (performance): Avoid downloading and unpacking GUT on ever…
ikostan abfe2b3
Merge pull request #576 from ikostan/create-new-script-directory-skel…
ikostan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (testing): A 10-second global pytest timeout may be too aggressive for Playwright end-to-end runs.
On slower or loaded CI runners, Playwright tests often run longer than 10 seconds, so this global timeout is likely to cause flaky failures rather than catch real regressions. Consider a higher default (e.g., 60–120 seconds) and only tighten timeouts for specific tests that must be short-lived.