Repository navigation
Add Menu SFX bus, AudioWebBridge, and UI navigation sounds #500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from 7 commits
Commits
Show all changes
101 commits
Select commit
Hold shift + click to select a range
cc4f00d
Merge pull request #445 from ikostan/main
ikostan 6c01e4d
Merge pull request #484 from ikostan/main
ikostan 1258204
Create ui_navigation.mp3
espanakosta-jpg 2c86f40
Add UI Volume Controls to Options Menu & Sub-Issue 1: UI Navigation &…
ikostan 69b4c4e
Update globals.gd
ikostan 2fe7d69
Update audio_settings.gd
ikostan 623867c
Update audio_manager.gd
ikostan ff20858
Update audio_manager.gd
ikostan c5a53cf
issue (bug_risk): Menu slider mute state should likely use menu_muted…
ikostan cf566a0
Fix the copied tooltips for the menu row.
ikostan f9ae750
Include menu_label in _update_label_colors().
ikostan 0cd9c9d
Merge branch 'SFX' of https://github.com/ikostan/SkyLockAssault into SFX
espanakosta-jpg b80751d
Delete ui_navigation.mp3
espanakosta-jpg b200cf3
Create ui_navigation.wav
espanakosta-jpg 74b14bd
Create ui_navigation.wav.import
espanakosta-jpg 1f65dea
Create ui_navigation.mp3
espanakosta-jpg 33d721b
Create ui_navigation.mp3.import
espanakosta-jpg 280e757
Update default_bus_layout.tres
espanakosta-jpg f0cebe3
Update ui_navigation.wav.import
espanakosta-jpg 06a5fd0
Delete ui_navigation.mp3
espanakosta-jpg 6dc8741
Delete ui_navigation.mp3.import
espanakosta-jpg e2f2489
Update ui_navigation.wav
espanakosta-jpg 5be2d23
Delete ui_navigation.wav.import
espanakosta-jpg 7f32d3d
Delete ui_navigation.wav
espanakosta-jpg cbdefba
Create ui_navigation.wav
espanakosta-jpg b3004c5
Create ui_navigation.wav.import
espanakosta-jpg 928260f
Update globals.gd
ikostan 88c87ef
Step 1: Add Broadcasters
ikostan efdb2e9
Update audio_manager.gd
ikostan b83df50
Step 2: Create the Bridge
ikostan 711e957
Step 3: Create the Bridge
ikostan e1b11cb
Step 3 & 4: Migrate JS → Godot
ikostan eee0b45
Step 5. Purge the UI (clean up audio_settings.gd)
ikostan 2cb41b3
Update audio_web_bridge.gd
ikostan 9ea7ad6
Update globals.gd
ikostan 0d5171f
Update audio_settings.gd
ikostan e8fff44
Update audio_web_bridge.gd
ikostan ebf09fe
Update test_audio_unexpected_exit.gd
ikostan 1e3f044
Update test_audio_settings.gd
ikostan 4a1a5f1
Update audio_settings.gd
ikostan 366dac8
Update test_audio_settings.gd
ikostan e294b30
Update audio_settings.gd
ikostan 51a6d5b
Update test_basic_save_load_without_other_settings.gd
ikostan d4f71e4
Add focus navigation properties to SFXMenu and update surrounding nodes.
ikostan 68fabdd
Update audio_settings.tscn
ikostan 70c0963
Update project.godot
ikostan 4a834ca
[FEATURE] Unit Test Suite for AudioWebBridge #504
ikostan 76cd14c
Update test_audio_web_bridge.gd
ikostan 5759663
Update test_audio_web_bridge.gd
ikostan 080ef42
Update test_audio_web_bridge.gd
ikostan 1840647
Update audio_web_bridge.gd
ikostan fbcd118
Update test_volume_slider.gd
ikostan 7749947
Update audio_settings.gd
ikostan 5180533
Update audio_web_bridge.gd
ikostan 9c567b1
Update volume_sliders_mutes_test.py
ikostan fcf45a6
Update audio_settings.gd
ikostan a139ce0
style: format code with Black and isort
deepsource-autofix[bot] 6bf01a9
Update audio_settings.gd
ikostan be4e25d
Update back_flow_test.py
ikostan 82d61ec
Update audio_settings.gd
ikostan 7056810
Merge branch 'SFX' of https://github.com/ikostan/SkyLockAssault into SFX
ikostan 35003d2
style: format code with Black and isort
deepsource-autofix[bot] 4c89b90
Update audio_settings.gd
ikostan e0d1f2b
Merge branch 'SFX' of https://github.com/ikostan/SkyLockAssault into SFX
ikostan 2715d23
Update audio_web_bridge.gd
ikostan d809538
Update audio_settings.gd
ikostan 81db6dd
Update ui_navigation.wav
espanakosta-jpg a1a4993
Merge branch 'SFX' of https://github.com/ikostan/SkyLockAssault into SFX
espanakosta-jpg 7169c85
Reset AudioManager in the fixture.
ikostan b05562f
The two Back handlers have diverged.
ikostan 0e476c6
Update advanced_settings.gd
ikostan 5d3c775
Update advanced_settings.gd
ikostan 4675e3a
Update advanced_settings.gd
ikostan c7b7e7e
issue (bug_risk): Global nav SFX in _input may trigger in non‑UI cont…
ikostan a8377eb
Update test_globals_resource.gd
ikostan 9c574b7
Update test_settings_observer.gd
ikostan 11c9f4c
Update globals.gd
ikostan 0bce76a
Update globals.gd
ikostan a874899
Update globals.gd
ikostan e53b252
Update globals.gd
ikostan 4456c19
Update audio_settings.gd
ikostan be761b7
Update audio_settings.gd
ikostan 2972370
Update audio_settings.gd
ikostan 89994d5
The two Back handlers have diverged.
ikostan ce589c4
Update test_audio_settings.gd
ikostan fedfd9a
Replace is_echo() debouncing with is_action_just_pressed() for proper…
ikostan 6026c22
Update globals.gd
ikostan 7bda25a
Update globals.gd
ikostan 64ea19e
Triple-nested call_deferred appears to be a mistake.
ikostan b572c40
Update scripts/audio_web_bridge.gd
ikostan 5c14205
Mute toggle handler lacks parent-mute guard.
ikostan 5f4296b
Merge branch 'SFX' of https://github.com/ikostan/SkyLockAssault into SFX
ikostan 7ff62e7
Update scripts/audio_settings.gd
ikostan d7da407
issue (bug_risk): Consider disconnecting AudioManager signals on exit…
ikostan bcd0ed8
Update audio_settings.gd
ikostan d467cfa
Update audio_settings.gd
ikostan 9793b73
suggestion (performance): The per-navigation DEBUG log can be very no…
ikostan bf7d5ec
Update scripts/audio_settings.gd
ikostan f4f40e3
Merge branch 'SFX' of https://github.com/ikostan/SkyLockAssault into SFX
ikostan b33d179
Update audio_settings.gd
ikostan a8e1479
Update audio_settings.gd
ikostan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| [gd_scene load_steps=4 format=3 uid="uid://cm2nruujxhdhu"] | ||
|
|
||
| [ext_resource type="FontFile" uid="uid://borwvgqdgawbj" path="res://files/fonts/EMPIREST.TTF" id="1_f34wo"] | ||
| [ext_resource type="Script" uid="uid://8hd1kvmb5bt1" path="res://scripts/volume_slider.gd" id="2_3a0os"] | ||
|
|
||
| [sub_resource type="StyleBoxFlat" id="StyleBoxFlat_y238m"] | ||
| corner_radius_top_left = 20 | ||
| corner_radius_top_right = 20 | ||
| corner_radius_bottom_right = 20 | ||
| corner_radius_bottom_left = 20 | ||
| shadow_size = 5 | ||
|
|
||
| [node name="SFXMenu" type="Control"] | ||
| custom_minimum_size = Vector2(385, 24) | ||
| layout_mode = 3 | ||
| anchors_preset = 0 | ||
| offset_right = 400.0 | ||
| offset_bottom = 24.0 | ||
| size_flags_horizontal = 3 | ||
| size_flags_vertical = 3 | ||
| tooltip_text = "SFX Rotors Volume Control" | ||
|
ikostan marked this conversation as resolved.
Resolved
|
||
|
|
||
| [node name="SFXMenuLabel" type="Label" parent="."] | ||
| layout_mode = 0 | ||
| offset_top = 3.0 | ||
| offset_right = 100.0 | ||
| offset_bottom = 21.0 | ||
| size_flags_horizontal = 0 | ||
| theme_override_fonts/font = ExtResource("1_f34wo") | ||
| theme_override_font_sizes/font_size = 18 | ||
| text = "{MENU}" | ||
|
|
||
| [node name="HSlider" type="HSlider" parent="."] | ||
| layout_direction = 2 | ||
| layout_mode = 0 | ||
| offset_left = 125.0 | ||
| offset_right = 345.0 | ||
| offset_bottom = 24.0 | ||
| size_flags_horizontal = 3 | ||
| size_flags_vertical = 1 | ||
| tooltip_text = "Slide to control menu effects volume." | ||
| focus_neighbor_right = NodePath("../Mute") | ||
| focus_next = NodePath("../Mute") | ||
| max_value = 1.0 | ||
| step = 0.05 | ||
| tick_count = 16 | ||
| ticks_on_borders = true | ||
| script = ExtResource("2_3a0os") | ||
| bus_name = "SFX_Menu" | ||
|
|
||
| [node name="Mute" type="CheckButton" parent="."] | ||
| layout_direction = 1 | ||
| layout_mode = 0 | ||
| offset_left = 360.0 | ||
| offset_right = 404.0 | ||
| offset_bottom = 24.0 | ||
| size_flags_horizontal = 8 | ||
| tooltip_text = "Mute Rotors" | ||
| focus_neighbor_left = NodePath("../HSlider") | ||
| focus_previous = NodePath("../HSlider") | ||
| theme_override_styles/focus = SubResource("StyleBoxFlat_y238m") | ||
| button_pressed = true | ||
| icon_alignment = 2 | ||
| vertical_icon_alignment = 0 | ||
| expand_icon = true | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.