Skip to content

Fix missing token per second for webui after function call update #648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 27, 2025
+29 −24
Merged

Fix missing token per second for webui after function call update #648

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
82d9bc0
bug fix no timings after tool update
Jul 24, 2025
608ff76
webui: move preset settings to top
Jul 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified examples/server/public/index.html.gz
View file
Open in desktop
Binary file not shown.
6 changes: 5 additions & 1 deletion examples/server/server.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2889,7 +2889,11 @@ static std::vector<json> format_partial_response_oaicompat(server_task_result ta
};
streaming_chunks.push_back(finish_chunk);
}

if (server_task_result_dict.count(task_result.id) > 0)
{
for (auto& chunk : streaming_chunks)
chunk.push_back({ "timings", server_task_result_dict[task_result.id].timings.to_json() });
}
// Return streaming chunks (could be just final chunk if no diffs)
if (!streaming_chunks.empty()) {
return streaming_chunks;
Expand Down
4 changes: 2 additions & 2 deletions examples/server/webui/dist/index.html
View file
Open in desktop

Large diffs are not rendered by default.

41 changes: 21 additions & 20 deletions examples/server/webui/src/components/SettingDialog.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,26 @@ const SETTING_SECTIONS = (
localConfig: typeof CONFIG_DEFAULT,
setLocalConfig: (config: typeof CONFIG_DEFAULT) => void
): SettingSection[] => [
{
title: (
<>
<BookmarkIcon className={ICON_CLASSNAME} />
Presets
</>
),
fields: [
{
type: SettingInputType.CUSTOM,
key: 'custom', // dummy key for presets
component: () => (
<PresetsManager
currentConfig={localConfig}
onLoadPreset={setLocalConfig}
/>
),
},
],
},
{
title: (
<>
Expand Down Expand Up @@ -489,26 +509,7 @@ const SETTING_SECTIONS = (
},
],
},
{
title: (
<>
<BookmarkIcon className={ICON_CLASSNAME} />
Presets
</>
),
fields: [
{
type: SettingInputType.CUSTOM,
key: 'custom', // dummy key for presets
component: () => (
<PresetsManager
currentConfig={localConfig}
onLoadPreset={setLocalConfig}
/>
),
},
],
},

];

export default function SettingDialog({
Expand Down
2 changes: 1 addition & 1 deletion examples/server/webui/src/index.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ html {
.chat-bubble-base-300 {
--tw-bg-opacity: 1;
--tw-text-opacity: 1;
@apply bg-base-300 text-base-content;
@apply break-words bg-base-300 text-base-content;
}

/* Highlight.js */
Expand Down