Merged
Conversation
Contributor
|
Thanks a bunch, just tested and it is working again with With this in place, |
Contributor
|
This fixed the crashes I was having with SM graph and |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is a bit of a mess, but hopefully this works.
Basically for split mode graph we need some persistent state in the CUDA context. But the whole
ggml/llamathing does not really foresee such use case, so it all becomes very hacky.I fixed split mode
graphnot working when anmmprojfile is loaded in #1392. The reason it wasn't working was that when themmprojfile was being loaded, it created a new CUDA context, which overwrote the CUDA context of the main model. I removed the overwrite. But when one loads the main model using--no-mmap(something I never use myself), that creates a CUDA context to load the main model, but that is not the context that gets created later that we actually need. So, that makes split modegraphfail.Hopefully this PR covers all use cases.