Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On to R4 implementation of the new iqk quants.
First
IQ4_KWe get very signifiant performance gains on
ARM_NEONand more modest gains onAVX2/Zen4. I suspect myAVX2/Zen4implementation is not optimum, but I did not see a better way for now.Here is
PP-512for LLaMA-3.1-8B onZen4(Ryzen-7950X),ARM_NEON(M2-Max) andAVX2(Ryzen-5975WX)We get decent performance gains for TG as well.
Here results for TG-128 on LLaMA-3.1-8B with different numbers of threads: