fix: avoid crash #29
Merged
fix: avoid crash #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since `tree-sitter-cli` hardcoded the `-fno-exceptions` flag for the `tree-sitter test` command, the "avoid crash" build is not enabled in the source code by default, but it's enabled for the node/rust binding. To enable the "avoid crash" build for a custom binding, simply define the `TREE_SITTER_MARKDOWN_AVOID_CRASH` macro with `-fexceptions` flag enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24
This PR mitigates the crash issue with the cost of the parsed tree being inaccurate in the previously crashed cases, but the parsed tree should be accurate again once the typing finished if the assumption of the crash caused by unfinished typing is correct.
Since
tree-sitter-clihardcoded the-fno-exceptionsflag for thetree-sitter testcommand, the "avoid crash" build is not enabled in the source code by default, but it's enabled for the node/rust binding. To enable the "avoid crash" build for a custom binding, simply define theTREE_SITTER_MARKDOWN_AVOID_CRASHmacro with-fexceptionsflag enabled.