fix: no SEGFAULTs and assertion failures #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d the literal line break in unfinished inline stack
…reak in link definition
|
looking forward for this |
|
There is still an assertion error caused by the wrong precedence between link definitions and code spans (#18), but since it seems to be relatively hard to be triggered and the fix would require some non-trivial changes, I think it should probably be fine to merge this PR now so that others can give it a try. |
|
Thanks @ikatyang I'll test out tomorrow |
danielpunkass
pushed a commit
to danielpunkass/tree-sitter-markdown-ikatyang
that referenced
this pull request
Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14
Fixes #16
This is still WIP since there are still some errors could be found by the libfuzzer, this PR is aimed for showing the progress and it'll be merged if I cannot find any further error.