Add content type to streams #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikatson
reviewed
Aug 2, 2024
crates/librqbit/src/api.rs
Outdated
| ) -> Result<&'static str> { | ||
| let file_name = info | ||
| .iter_filenames_and_lengths()? | ||
| .enumerate() |
There was a problem hiding this comment.
Rather then enumerate().find_map(if ...) wouldn't just nth(file_idx) work?
There was a problem hiding this comment.
Absolutely, bad me - cannot remember all those cool iterators combinators - fixed in next commit.
ikatson
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is motivated by need to stream/open/download other files from torrent than mp4/mkv/avi.
Usecase is mainly if rqbit is running on other computer (like nas server) - so I can see what is in other files, download them to notebook etc. Ad there are other media files, which streams nicely in browser - mp3 ....
Changes:
Note: for some reason files
crates/librqbit/webui/dist, where checked in to repo, but they are also in .gitignore - I guess they are result of your release build process - so I did not included them.