Skip to content

WAPM publishing#31

Closed
jcaesar wants to merge 4 commits intoikanago:mainfrom
jcaesar:main
Closed

WAPM publishing#31
jcaesar wants to merge 4 commits intoikanago:mainfrom
jcaesar:main

Conversation

@jcaesar
Copy link
Contributor

@jcaesar jcaesar commented May 23, 2022

Implements #29.

I've tested this on some other repository, but I obviously can't test it on yours. So there might be some quirks.

For the login token, you'll have to:

  • Log in to wapm.io,
  • click your user account icon (top right),
  • Settings,
  • Access Tokens,
  • Create new Token.

And then register that as a new repository secret on this github repo.

@jcaesar
Copy link
Contributor Author

jcaesar commented May 25, 2022

Actually, can I ask you to wait with merging this for a bit? It might be necessary to downgrade rust to 1.56 for the release build because of this bug.

@ikanago
Copy link
Owner

ikanago commented May 27, 2022

OK, please notify me after the bug is fixed.

Copy link
Owner

@ikanago ikanago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the bug is fixed, I will test these workflows.

echo "Version: ${{ env.PROJECT_VERSION }}"

- name: Check git tag against toml values
if: ${{ matrix.job.os != 'windows-2019' }} # windows too weird
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These files are identical among jobs, so just checking on one job, ubuntu-20.04 for example, is enough.

Copy link
Contributor Author

@jcaesar jcaesar May 27, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is what I thought at first, too, but tell me: Won't the publish step for the other os still run, creating a release with some missing files?

- name: Publish
if: ${{ contains(github.ref, '/tags/') }}
uses: softprops/action-gh-release@v1
with:
files: ${{ env.PKG_PATH }}
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

@jcaesar
Copy link
Contributor Author

jcaesar commented Jul 9, 2024

I give up. Instead of that bug above getting fixed, webassembly.sh is getting more and more broken. You could of course publish to wapm.io for other reasons, but I'm not quite sure what those would be.

(Unrelated: I might package this for nixpkgs, though. [Edit:] Easy.)

@jcaesar jcaesar closed this Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants