Skip to content

Switch to cryptography to resolve performance concerns.#232

Merged
ikalchev merged 1 commit intoikalchev:devfrom
bdraco:faster_crypto
Mar 28, 2020
Merged

Switch to cryptography to resolve performance concerns.#232
ikalchev merged 1 commit intoikalchev:devfrom
bdraco:faster_crypto

Conversation

@bdraco
Copy link
Copy Markdown
Contributor

@bdraco bdraco commented Mar 27, 2020

Solves issue #228

@ikalchev
Copy link
Copy Markdown
Owner

Hi - sorry the late reply. I will review this tomorrow and probably merge and release.

Best regards,
Ivan

@bdraco
Copy link
Copy Markdown
Contributor Author

bdraco commented Mar 27, 2020

Hi - sorry the late reply. I will review this tomorrow and probably merge and release.

Best regards,
Ivan

If you can, #229 is waiting as well

@codecov-io
Copy link
Copy Markdown

codecov-io commented Mar 27, 2020

Codecov Report

Merging #232 into dev will increase coverage by 0.08%.
The diff coverage is 55.00%.

@@            Coverage Diff             @@
##              dev     #232      +/-   ##
==========================================
+ Coverage   62.08%   62.17%   +0.08%     
==========================================
  Files          16       16              
  Lines        1704     1708       +4     
  Branches      176      176              
==========================================
+ Hits         1058     1062       +4     
  Misses        606      606              
  Partials       40       40              
Impacted Files Coverage Δ
pyhap/hap_server.py 37.11% <55.00%> (+0.51%) ⬆️

@ikalchev ikalchev merged commit 214c047 into ikalchev:dev Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants