Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downstreamed changes from @embroider/[email protected] #122

Merged
merged 4 commits into from
Dec 20, 2023

Conversation

ijlee2
Copy link
Owner

@ijlee2 ijlee2 commented Dec 20, 2023

Description

By replacing a few Babel plugins with decorator-transforms, we can ship fewer bytes and avoid the need to transpile other class features.

Before After
Package size 5.6 kB 5.6 kB
Unpacked size 15.1 kB 14.9 kB
Total files 17 17

Note, unlike in ember-container-query, the size reduction is minimal. This may be because embroider-css-modules currently provides just 1 helper.

@ijlee2 ijlee2 added the enhance: dependency Issue asks for a new or updated dependency label Dec 20, 2023
Copy link

netlify bot commented Dec 20, 2023

Deploy Preview for embroider-css-modules ready!

Name Link
🔨 Latest commit 9f6867c
🔍 Latest deploy log https://app.netlify.com/sites/embroider-css-modules/deploys/65830b7ab9dda70008f8d82a
😎 Deploy Preview https://deploy-preview-122--embroider-css-modules.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ijlee2 ijlee2 marked this pull request as ready for review December 20, 2023 15:40
@ijlee2 ijlee2 merged commit a965de5 into main Dec 20, 2023
9 checks passed
@ijlee2 ijlee2 deleted the downstream-changes-from-addon-blueprint branch December 20, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhance: dependency Issue asks for a new or updated dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant