Skip to content

Commit

Permalink
Made pnpm settings stricter (#154)
Browse files Browse the repository at this point in the history
* chore: Updated pnpm to 9.9.0

* chore: Set auto-install-peers and resolve-peers-from-workspace-root to false

* chore: Updated lockfile

* chore: Added changeset

---------

Co-authored-by: ijlee2 <[email protected]>
  • Loading branch information
ijlee2 and ijlee2 authored Sep 5, 2024
1 parent 8e759d3 commit 08fb866
Show file tree
Hide file tree
Showing 5 changed files with 44 additions and 277 deletions.
11 changes: 11 additions & 0 deletions .changeset/tidy-weeks-collect.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
---
"my-app": patch
"my-app-with-ember-css-modules": patch
"my-v1-addon": patch
"my-v2-addon": patch
"embroider-css-modules": patch
"test-app-for-embroider-css-modules": patch
"test-app-for-my-v2-addon": patch
---

Made pnpm settings stricter
10 changes: 0 additions & 10 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,6 @@ jobs:

- name: Set up pnpm
uses: pnpm/action-setup@v4
# with:
# version: 9

- name: Use Node.js ${{ env.NODE_VERSION }}
uses: actions/setup-node@v4
Expand Down Expand Up @@ -75,8 +73,6 @@ jobs:

- name: Set up pnpm
uses: pnpm/action-setup@v4
# with:
# version: 9

- name: Use Node.js ${{ env.NODE_VERSION }}
uses: actions/setup-node@v4
Expand Down Expand Up @@ -126,8 +122,6 @@ jobs:

- name: Set up pnpm
uses: pnpm/action-setup@v4
# with:
# version: 9

- name: Use Node.js ${{ env.NODE_VERSION }}
uses: actions/setup-node@v4
Expand Down Expand Up @@ -167,8 +161,6 @@ jobs:

- name: Set up pnpm
uses: pnpm/action-setup@v4
# with:
# version: 9

- name: Use Node.js ${{ env.NODE_VERSION }}
uses: actions/setup-node@v4
Expand Down Expand Up @@ -208,8 +200,6 @@ jobs:

- name: Set up pnpm
uses: pnpm/action-setup@v4
# with:
# version: 9

- name: Use Node.js ${{ env.NODE_VERSION }}
uses: actions/setup-node@v4
Expand Down
4 changes: 3 additions & 1 deletion .npmrc
Original file line number Diff line number Diff line change
@@ -1 +1,3 @@
strict-peer-dependencies=false
# https://github.com/emberjs/rfcs/pull/907
auto-install-peers=false
resolve-peers-from-workspace-root=false
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"concurrently": "^8.2.2",
"update-workspace-root-version": "^0.3.0"
},
"packageManager": "pnpm@9.7.0",
"packageManager": "pnpm@9.9.0",
"engines": {
"node": "18.* || >= 20",
"pnpm": ">= 9"
Expand Down
Loading

0 comments on commit 08fb866

Please sign in to comment.