Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for eu-ch2 region in IAM endpoints.go #77

Merged
merged 2 commits into from
Jan 6, 2024

Conversation

dombisza
Copy link
Contributor

@dombisza dombisza commented Dec 19, 2023

hello there,

eu-ch2 aka swisscloud uses a different API endpoint naming convention, I have updated common/endpoints/endpoints.go to support swisscloud IAM endpoint. Ran go fmt and tested auth on eu-de and on eu-ch2 as well. Not sure if there is any test suites I should be using when contributing to your project, if I missed it, please point me to the direction thanks!

./otc-auth login iam --os-username $MYUSER --os-password $MYPW --os-domain-name $MYDOMAIN --region eu-ch2             
2023/12/19 15:34:10 info: cloud REDACTED loaded successfully and set to active.
2023/12/19 15:34:10 info: retrieving unscoped token for active cloud...
2023/12/19 15:34:11 info: fetching projects for cloud REDACTED
2023/12/19 15:34:13 info: projects for active cloud:
REDACTED
REDACTED
REDACTED
2023/12/19 15:34:27 info: scoped token acquired successfully
2023/12/19 15:34:27 info: successfully obtained unscoped token!

@Ninja243
Copy link
Contributor

Ninja243 commented Jan 4, 2024

Thanks for the PR! I'd be happy to merge this as soon as the issue found by our linter is fixed!

@dombisza
Copy link
Contributor Author

dombisza commented Jan 5, 2024

@Ninja243 thanks for the hint, fixed the return

@Ninja243 Ninja243 merged commit b482b30 into iits-consulting:main Jan 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants