Allow offical plugins to be searched on mobile app #1232
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This corresponds to #1228 which suggest making plugins searchable, to be turned on or off more quickly. Here is my implementation, it involves populating a SQLite database which is queried whenever a user types in the search view. It shows the names of all plugins that start with the query which are search suggestions. When a suggestion is tapped, the plugin is toggled as if it's checkbox was clicked and a Toast notifies the user.
The search widget shouldn't interfere with the add script feature already in place. It turns out the activity is not launched in
singleTop
mode so a new activity is created to handle the search, but I handle the suggestion inonCreate()
and then callfinish()
so the activity animation doesn't occur and there are no other side effects. I made changes toPluginPreferenceActivity.java
, some are changes to existing methods while others are new methods.