Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow offical plugins to be searched on mobile app #1232

Closed
wants to merge 1 commit into from
Closed

Allow offical plugins to be searched on mobile app #1232

wants to merge 1 commit into from

Conversation

IamTechknow
Copy link

This corresponds to #1228 which suggest making plugins searchable, to be turned on or off more quickly. Here is my implementation, it involves populating a SQLite database which is queried whenever a user types in the search view. It shows the names of all plugins that start with the query which are search suggestions. When a suggestion is tapped, the plugin is toggled as if it's checkbox was clicked and a Toast notifies the user.

The search widget shouldn't interfere with the add script feature already in place. It turns out the activity is not launched in singleTop mode so a new activity is created to handle the search, but I handle the suggestion in onCreate() and then call finish() so the activity animation doesn't occur and there are no other side effects. I made changes to PluginPreferenceActivity.java, some are changes to existing methods while others are new methods.

@IamTechknow
Copy link
Author

Closing this now because there's no activity for a long time and the need for this is questionable. I remember creating this PR to see if this was possible

@johnd0e
Copy link

johnd0e commented Jun 21, 2021

@IamTechknow

In fact this is really needed feature, and there is activity in modern fork - iitc-ce.
Feel free to post PR there, we will be happy to include that functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants