Portals-list fix

[McBen]

Portals-list fix for #1161

but 'cause of "Always leave the campground cleaner than you found it." I had to apply some more refactoring.

[hayeswise]

Before committing these changes, would you mind adding an id to the toolbox control? This will allow other plugins to create logical toolbox groupings of controls of other plugins.

An id example:

    $('#toolbox').append('<a id="portalslist-portalList" onclick="window.plugin.portalslist.displayPL()" title="Display a list of portals in the current view [t]" accesskey="t">Portals list</a>');

For the id, I used the pattern <plugin-object-name>-<control-name>. The plugin-object-name facilitates (but does not enforce) achieving unique ids across the plugins.

Thanks!

[pleasantone]

Looks like we both had similar ideas. Please see #1190

[McBen]

closed because stale project