Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new plugin extend-poly-lines.user.js #1138

Closed
wants to merge 3 commits into from

Conversation

TheSned
Copy link

@TheSned TheSned commented Oct 12, 2016

Please consider adding my plugin to the core code base. Thanks!

@TheSned
Copy link
Author

TheSned commented Oct 13, 2016

extend-polygon-lines
extend-polyline-lines

s-chizhik added a commit to s-chizhik/ingress-intel-total-conversion that referenced this pull request Oct 17, 2016
@ryantheleach
Copy link

ryantheleach commented Nov 12, 2016

Thanks for this, I'd been struggling working it out.

I think I prefer the approach I was trying to take, that instead of extending all poly lines, you were able to draw construction lines / extend specific lines, however I never finished it :S

Sorry for the poor gif, my cursor is actually to the right where the tooltip is.
image

*Edit: * gif failed to upload: https://i.gyazo.com/ba6230730426acc66dee0b32c8057db7.gif

Anyway, by snapping to the portals you can be sure that you are following the right line, then from there it would draw out as far as you drew, a dotted line much like you have. except it would have a beginning and end and not give you a big mess if you zoom out on multiple layers.

@TheSned
Copy link
Author

TheSned commented Nov 12, 2016

I agree that it would be nice to be able to choose which lines are extended and maybe even by how much. However, I use this on mobile with auto draw quite a bit, which doesn't seem like it would work well with your method.

@ryantheleach
Copy link

Alternately, it's only the outer layers that are needed to be drawn right?
Or if you do need the layers underneath, they could do better with being a different color, just to more easily distinguish them?

@TheSned
Copy link
Author

TheSned commented Nov 14, 2016

I've thought about maybe an option or "layer" to include just the top layer of drawn items or not. However, I haven't had time to code something like that. It depends on the plan you're working on. Sometimes that's all you'd need, but if you have multiple spines, then just the top layer wouldn't work.

@ryantheleach
Copy link

@TheSned I see what you mean about auto-draw and mobile. I've only just started using it myself since my Home PC power supply blew.

Maybe toggle the behaviour depending on whether it's on desktop or mobile?

@TheSned
Copy link
Author

TheSned commented Jan 26, 2017

I will not be making any more changes to this plugin. I have lots of other ideas for plugin development and will be focusing any free time I have on those ideas. If seeing the extra lines is annoying when zooming out, you can just turn off the layer. Feel free to fork my branch, tweak the plugin yourself, and make a separate pull request.

@TheSned TheSned closed this Apr 9, 2021
@TheSned TheSned deleted the AddExtendPolyLinesPlugin branch April 9, 2021 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants