Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change visited neutral portal fill when uniques are highlighted #1119

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

benjamincuningham
Copy link

The orange fill on neutral portals is too close to the red fill for non-visited portals. The change I am proposing sets the fill of visited neutral portals to light grey. This creates a clear contrast.

The orange fill on neutral portals is too close to the red fill for non-visited portals. The change I am proposing sets the fill of visited neutral portals to light grey. This creates a clear contrast.
@mxxcon
Copy link

mxxcon commented Jul 17, 2016

Screenshot of what it looks like? 😄

@benjamincuningham
Copy link
Author

@maxxcon, I can on Monday.

After playing with it some more, I actually set all of my visited portals to light grey fill. This is probably not the way most people would like to leave it all the time. I only turn on the highlighting when I need it.

What does anyone else think would be best? Do you take issue with the lack of contrast?

@mxxcon
Copy link

mxxcon commented Jul 17, 2016

yes, neutral-unvisited could be more contrast.

@benjamincuningham
Copy link
Author

uniques

@3ch01c
Copy link
Contributor

3ch01c commented Jul 18, 2016

I think yellow/orange/red/magenta are the standard highlighter colors. Neutral portals used to be grey, but I think there were visibility issues so they were changed to orange. There's a uniques fork out there that adds layers so you can hide visited/captured portals.

@mxxcon
Copy link

mxxcon commented Jul 18, 2016

@3ch01c the issue is that neutral portals and unvisited neutral portals look very similar...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants