Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different colours for ENL and RES ant-trails #1091

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zinob
Copy link

@zinob zinob commented Jan 9, 2016

Changed the colour of the ENL ant-trail in order to make it easier to distinguish between ENL and RES agents when trying to coordinate events.
Made the dash-pattern slightly asymmetric so that it would be possible-ish to determine which way players move (and arrow would be better but that would be a bigger change).

Changed the colour of the ENL ant-trail in order to make it easier to distinguish between ENL and RES agents when trying to coordinate events.
Made the dash-pattern slightly asymetric so that it would be possible-ish to determine which way players move (and arrow would be better but that would be a bigger change).
@davidlinse
Copy link

👍

@mxxcon
Copy link

mxxcon commented Jan 19, 2016

Screenshot of what it looks like?
Also would it work with Canvas plugin enabled?

@zinob
Copy link
Author

zinob commented Jan 30, 2016

The change is minimal so I don't see why it would have any adverse interactions with the canvas plugin.
I haven't had much luck with capturing any action lately but here are two screenshots:

MapQuest OSM:
image

Google Default Ingress Map:
image

@mxxcon
Copy link

mxxcon commented Jan 30, 2016

The problem with canvas plugin is that any dashed line becomes solid.

@FesterCluck
Copy link
Contributor

@mxxcon @zinob A fix for canvas woes: In the main IITC js, in _updateStyle, _updatePath, and _drawPath for canvas rendering, code similar to this should be added:

        if (this.options.dashArray) {
            var da = typeof(this.options.dashArray) === "string" ? this.options.dashArray.split(",").map(function(el,ix,ar) { return parseInt(el); }) : this.options.dashArray;
            this._ctx.setLineDash(da);
        }

@FesterCluck
Copy link
Contributor

Supporting pull request: #1114

@FesterCluck
Copy link
Contributor

Small note: For equitable contrast, it would probably be best to change the Eln trail to the Purple color, and change the Res trail to an Orange.

@FesterCluck
Copy link
Contributor

Lines 27-28:


window.PLAYER_TRACKER_RES_LINE_COLOUR = '#FFA500';
window.PLAYER_TRACKER_ENL_LINE_COLOUR = '#FF00FD';

@zinob
Copy link
Author

zinob commented Jun 25, 2016

Allegedly i have severely impaired color vision but to me this results in a blue ENL and a green RES which is confusing..
When selecting the colors I spent some (but not a tremendous) amount of time to get both trails at least usable. To me, my suggestion results in ENL beeing more visible when using original Ingress map or OSM-Positron while RES is easier to follow on standard OSM.
image

For my own use i actually added a white-shadow to ENL but thought it gave to much attention to ENL so I left it out for equity's sake.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants