Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add detection for iOS #1025

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

HubertZhang
Copy link

Avoid loading scripts on Google login page.
Add detection for iOS devices.

@pleasantone
Copy link
Contributor

I'm curious about the main.js commit.
I think the iOS app should only inject the js on pages that are under http(s)://...ingress.com/intel as opposed to having the js get injected everywhere and then quit out of.

On Jul 27, 2015, at 1:11 AM, Hubert Zhang [email protected] wrote:

Avoid loading scripts on Google login page.
Add detection for iOS devices.

You can view, comment on, or merge this pull request online at:

#1025

Commit Summary

add detection of account.google
add detection for iOS
File Changes

M code/smartphone.js (3)
M main.js (4)
Patch Links:

https://github.com/jonatkins/ingress-intel-total-conversion/pull/1025.patch
https://github.com/jonatkins/ingress-intel-total-conversion/pull/1025.diff

Reply to this email directly or view it on GitHub.

@HubertZhang
Copy link
Author

After several test, WKWebview I used in iOS app can store several user scripts when it is initialized and will inject those scripts to every page it loaded. The scripts injected cannot be controlled once this WKWebview is created and will influence Google account login page...

@HubertZhang HubertZhang changed the title add two detection may used in iOS add detection for iOS Aug 15, 2015
@HubertZhang
Copy link
Author

I've removed detection of Google Account which is not needed by iOS version any more

modos189 added a commit to IITC-CE/ingress-intel-total-conversion that referenced this pull request Dec 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants