Skip to content

Conversation

PsypherPunk
Copy link
Contributor

SWFReplayRenderer moved to an external file, fixin #176 . I've left it as part of the configuration via <import resource="SWFReplayRenderer.xml"/> in order to maintain consistency in the default config.

@kris-sigur kris-sigur added this to the 2.1.0 Minor Release milestone Feb 2, 2015
@RogerMathisen
Copy link
Contributor

I have tried out this pull request both downloading the changes from GIT and manually making the changes based on the changelog, and I get an error with the import statement:

It seems the Spring framework is having issues with the import statement being inside the bean:

The error message I get when starting up the Tomcat instance indicates that tags are not allowed inside tags.

Am I doing something wrong, or does the import need to be rewritten?

@PsypherPunk
Copy link
Contributor Author

I've moved the import and included a <ref...>@RogerMathisen, could you verify that this doesn't throw the same error?

@RogerMathisen
Copy link
Contributor

The tag won't work unless you set an ID for the referenced bean in "SWFReplayRenderer.xml".

Also you should consider adding an XML-tag at the start of the file just to make it valid and in line with the other XML-files in the project:

I have made these changes locally, and it seems to do the trick.

@kris-sigur kris-sigur merged commit a20a5ef into iipc:master May 15, 2015
kris-sigur added a commit that referenced this pull request May 15, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants