Skip to content

docs(acp): drop stale 'deferred to v0.2' from README header - #87

Merged
rohitg00 merged 1 commit into
mainfrom
fix/acp-readme-status
May 6, 2026
Merged

docs(acp): drop stale 'deferred to v0.2' from README header#87
rohitg00 merged 1 commit into
mainfrom
fix/acp-readme-status

Conversation

@rohitg00

@rohitg00 rohitg00 commented May 6, 2026

Copy link
Copy Markdown
Contributor

Summary

PR #86 shipped session/resume, session/set_mode, and session/set_config_option, but the acp README header still said reverse-RPC paths are "deferred to v0.2". That line conflated:

  • Three client→agent methods (now done in feat(acp): session/resume, set_mode, set_config_option #86)
  • The reverse-RPC surface (session/request_permission, fs/*, terminal/* — still deferred, but "v0.2" isn't accurate framing for them either since they only land when external ACP agents need them via acp-client)

Change

Replaces the misleading status line with explicit per-method enumeration:

  • All eleven client→agent methods listed as implemented
  • Reverse-RPC paths spelled out fully (fs/{read,write}_text_file, terminal/{create,kill,output,release,wait_for_exit})
  • Points readers at the existing Methods table for full status

No code changes.

Test plan

  • Header text matches the actual code surface in acp/src/handler.rs
  • Method list aligns with the Methods table later in the README

PR #86 implemented session/resume, session/set_mode, and
session/set_config_option, but the README header still said reverse-RPC
paths are 'deferred to v0.2'. That line conflated the three new
client->agent methods (now done) with the reverse-RPC surface (still
deferred), and v0.2 isn't accurate framing for the latter either since
those methods only land when external ACP agents (future acp-client)
need them.

Replaces the line with an explicit per-method enumeration in the status
block, splitting client->agent (all eleven implemented) from reverse-RPC
(deferred). Points at the Methods table for full status.
@coderabbitai

coderabbitai Bot commented May 6, 2026

Copy link
Copy Markdown

Warning

Rate limit exceeded

@rohitg00 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 4 minutes and 8 seconds before requesting another review.

To continue reviewing without waiting, purchase usage credits in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 61724b0e-b150-478f-a88f-b87b47b432e1

📥 Commits

Reviewing files that changed from the base of the PR and between cecd1a4 and 2d8c64e.

📒 Files selected for processing (1)
  • acp/README.md
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/acp-readme-status

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@rohitg00
rohitg00 merged commit 25db268 into main May 6, 2026
2 checks passed
@rohitg00
rohitg00 deleted the fix/acp-readme-status branch May 6, 2026 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant