(MOT-4503) feat(cron): schedules page as injectable console UI - #855
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
Next review available in: 22 minutes Limit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?Wait for the limit to reset, then comment An organization admin can change what happens after included review limits in Billing. How do review limits work?CodeRabbit enforces per-developer PR review limits within each organization. For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (24)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
skill-check — worker0 verified, 62 skipped (no docs/).
Four for four. Nicely done. |
Why
The cron worker's schedules page (MOT-4503) was reviewed and merged as #840, but into
feat/console-consistency, notmain. The page is not on main. This PR brings it to main.The original squash commit could not be cherry-picked: it predated main's SDK 0.23 migration (#604) and the
onConversationRequested/registerTranscriptRendereradditions, so replaying it would have reverted those. Instead the cron worker's own additions are rebuilt on current main. The console-side plumbing the page relies on (onConversationRequested,selectConversation,composerModel, the transcript renderer registration) is already on main, so this PR touches onlycron/and the pnpm workspace.What
cronworker gains an injectable console UI: a schedules page (list, detail, manual form) plus a configuration form, registered throughcrates/console-ui(iii-console-ui) and the@iii-dev/console-uishared package, following the same pattern as the shell and state pages.cron/uiis added to the pnpm workspace; the bundle is built bybuild.rsand embedded in the binary.cronis bumped to the current SDK:iii-sdk = 0.23.0-rc.2, with the trigger-registration call sites moved toRegisterTriggerInput::new(...)andTriggerConfiggaining the newnamespacefield. Worker version 0.21.5 → 0.22.0.No
console/,packages/, orharness/changes: the console contracts this page needs already exist on main. (The harnessdecode_configrobustness fix that was bundled into #840 is not cron-specific and is left out; it can land on its own if wanted.)Verification
croncrate:cargo fmt --check,cargo clippy --all-targets --all-features -D warnings,cargo test(28).cron/ui:tsc --noEmit, esbuild bundle.cron/page.jsandcron/styles.css(GET /ui/cron/page.js→ 200), and the page mounts.Linear: MOT-4503