fix(harness): restore E2E dashboard build after benchmark-site removal - #806
fix(harness): restore E2E dashboard build after benchmark-site removal#806ytallo wants to merge 1 commit into
Conversation
PR #765 removed .github/benchmark-site/ with the release automations, but the local E2E dashboard added in #749 embeds that folder at compile time, so cargo build -p harness-e2e fails on a fresh checkout. Move the dashboard assets to harness/tests/e2e/assets/dashboard/ (their consumer), point the RustEmbed folder there, and drop the one test assertion that read the deleted publish script.
ytallo
added
the
no-ticket
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
skill-check — worker0 verified, 60 skipped (no docs/).
Four for four. Nicely done. |
|
Warning Review limit reached
Next review available in: 35 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (20)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
1 participant
Summary
cargo build -p harness-e2efails on a fresh checkout of main: the local E2E dashboard (#749) embeds.github/benchmark-site/at compile time viaRustEmbed, and #765 deleted that folder while removing the release automations. No PR workflow builds theharness-e2epackage (_harness-integration.ymlis scoped toharness-integration), so the break never surfaced on merge.This moves the dashboard assets into their consumer at
harness/tests/e2e/assets/dashboard/and points theRustEmbedfolder attribute there. The one test assertion that read the deletedpublish_harness_e2e_dashboard.pyscript is dropped; asset README paths updated.Note: ticket pending (Linear connector unavailable) — will retitle with the MOT prefix once created; please don't squash-merge before that.
Test plan
cargo build --locked -p harness-e2esucceeds from a fresh-checkout-equivalent treenode --test harness/tests/e2e/assets/dashboard/*.test.cjs— 39/39 passharness-e2e dashboardservesindex.htmlandstyles.css(HTTP 200) from the new embedcargo build -p harness-e2estep to PR CI so compile breaks in this package fail before merge