Skip to content

(MOT-4381) refactor(harness): migrate binary E2E assessments - #756

Merged
ytallo merged 1 commit into
mainfrom
refactor/harness-e2e-assessment-migrations
Aug 9, 2026
Merged

(MOT-4381) refactor(harness): migrate binary E2E assessments#756
ytallo merged 1 commit into
mainfrom
refactor/harness-e2e-assessment-migrations

Conversation

@ytallo

@ytallo ytallo commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Summary

  • migrate timer_wake, mechanical_reaction, and research_pipeline to static AssessmentSpec definitions
  • derive each scenario's criteria, hard gates, and awards from the same ordered definitions
  • use canonical criterion IDs for gates and advance each scenario contract to version 2
  • preserve prompts, evidence collection, scoring predicates, thresholds, cleanup, and blocking behavior

Why

These scenarios had exact one-to-one relationships between every hard gate and criterion award, but declared the same requirement multiple times. Reusing the Assessment abstraction prevents those definitions from drifting while keeping the runtime decision equivalent.

Validation

  • cargo fmt --manifest-path harness/Cargo.toml --all -- --check
  • cargo test --locked --manifest-path harness/Cargo.toml -p harness-e2e (111 passed)
  • cargo clippy --locked --manifest-path harness/Cargo.toml -p harness-e2e -- -D warnings
  • git diff --check

Depends on #755.

Refs MOT-4381

@vercel

vercel Bot commented Aug 7, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
workers Ready Ready Preview Aug 9, 2026 12:46pm
workers-tech-spec Ready Ready Preview Aug 9, 2026 12:46pm

Request Review

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@ytallo, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 56 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 6d93a3c7-4403-4bb6-9e90-c4ef7f150504

📥 Commits

Reviewing files that changed from the base of the PR and between 98ba042 and a2ea2a6.

📒 Files selected for processing (3)
  • harness/tests/e2e/src/scenarios/mechanical_reaction.rs
  • harness/tests/e2e/src/scenarios/research_pipeline.rs
  • harness/tests/e2e/src/scenarios/timer_wake.rs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

skill-check — worker

0 verified, 56 skipped (no docs/).

Layer Result
structure
vale
ai
render

Four for four. Nicely done.

@ytallo
ytallo marked this pull request as ready for review August 9, 2026 12:42
Base automatically changed from refactor/harness-e2e-assessments to main August 9, 2026 12:45
@ytallo
ytallo force-pushed the refactor/harness-e2e-assessment-migrations branch from 30d48d0 to a2ea2a6 Compare August 9, 2026 12:45
@ytallo
ytallo merged commit c0f3332 into main Aug 9, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant