(MOT-4299) fix(ci): run daily Harness benchmarks against Registry #735
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,73 @@ | ||
| #!/usr/bin/env python3 | ||
| """Create a deterministic identity for a Registry-resolved iii.lock.""" | ||
|
|
||
| from __future__ import annotations | ||
|
|
||
| import argparse | ||
| import hashlib | ||
| import json | ||
| import re | ||
| from pathlib import Path | ||
| from typing import Any | ||
|
|
||
| import yaml | ||
|
|
||
|
|
||
| WORKER_NAME = re.compile(r"^[a-z0-9][a-z0-9_-]*$") | ||
| EXACT_VERSION = re.compile( | ||
| r"^[0-9]+\.[0-9]+\.[0-9]+(-(experimental|alpha|beta))?$" | ||
| ) | ||
|
|
||
|
|
||
| def stack_identity(lock_path: Path) -> dict[str, Any]: | ||
| try: | ||
| document = yaml.safe_load(lock_path.read_text()) or {} | ||
| except (OSError, yaml.YAMLError) as error: | ||
| raise SystemExit(f"invalid_lock: cannot read {lock_path}: {error}") from error | ||
|
|
||
| workers = document.get("workers") if isinstance(document, dict) else None | ||
| if not isinstance(workers, dict) or not workers: | ||
| raise SystemExit("invalid_lock: workers must be a non-empty mapping") | ||
|
|
||
| versions: dict[str, str] = {} | ||
| for worker, record in sorted(workers.items()): | ||
| if not isinstance(worker, str) or not WORKER_NAME.fullmatch(worker): | ||
| raise SystemExit(f"invalid_lock: invalid worker name {worker!r}") | ||
| if not isinstance(record, dict): | ||
| raise SystemExit(f"invalid_lock: {worker} must be a mapping") | ||
| version = record.get("version") | ||
| if not isinstance(version, str) or not EXACT_VERSION.fullmatch(version): | ||
| raise SystemExit( | ||
| f"invalid_lock: {worker} must have an exact published version" | ||
| ) | ||
| versions[worker] = version | ||
|
|
||
| if "harness" not in versions: | ||
| raise SystemExit("invalid_lock: harness is required in the resolved stack") | ||
|
|
||
| return { | ||
| "schema_version": 1, | ||
| "lock_digest": hashlib.sha256(lock_path.read_bytes()).hexdigest(), | ||
| "stack_versions": versions, | ||
| } | ||
|
|
||
|
|
||
| def parse_args() -> argparse.Namespace: | ||
| parser = argparse.ArgumentParser() | ||
| parser.add_argument("--lock", type=Path, required=True) | ||
| parser.add_argument("--output", type=Path) | ||
| return parser.parse_args() | ||
|
|
||
|
|
||
| def main() -> None: | ||
| args = parse_args() | ||
| identity = stack_identity(args.lock) | ||
| rendered = json.dumps(identity, sort_keys=True) | ||
| if args.output: | ||
| args.output.parent.mkdir(parents=True, exist_ok=True) | ||
| args.output.write_text(rendered + "\n") | ||
| print(rendered) | ||
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| main() |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| from __future__ import annotations | ||
|
|
||
| import hashlib | ||
| import json | ||
| import subprocess | ||
| import sys | ||
| from pathlib import Path | ||
|
|
||
| import pytest | ||
| import yaml | ||
|
|
||
|
|
||
| SCRIPT = Path(__file__).parents[1] / "registry_stack_identity.py" | ||
|
|
||
|
|
||
| def run_identity( | ||
| tmp_path: Path, workers: dict[str, dict[str, str]] | ||
| ) -> subprocess.CompletedProcess[str]: | ||
| lock = tmp_path / "iii.lock" | ||
| lock.write_text(yaml.safe_dump({"workers": workers}, sort_keys=True)) | ||
| return subprocess.run( | ||
| [sys.executable, str(SCRIPT), "--lock", str(lock)], | ||
| text=True, | ||
| capture_output=True, | ||
| check=False, | ||
| ) | ||
|
|
||
|
|
||
| def test_returns_exact_versions_and_lock_digest(tmp_path: Path) -> None: | ||
| workers = { | ||
| "harness": {"version": "1.8.0"}, | ||
| "state": {"version": "0.22.0"}, | ||
| } | ||
| result = run_identity(tmp_path, workers) | ||
|
|
||
| assert result.returncode == 0, result.stderr | ||
| identity = json.loads(result.stdout) | ||
| lock = tmp_path / "iii.lock" | ||
| assert identity["stack_versions"] == {"harness": "1.8.0", "state": "0.22.0"} | ||
| assert identity["lock_digest"] == hashlib.sha256(lock.read_bytes()).hexdigest() | ||
|
|
||
|
|
||
| @pytest.mark.parametrize( | ||
| ("workers", "message"), | ||
| [ | ||
| ({"state": {"version": "0.22.0"}}, "harness is required"), | ||
| ({"harness": {"version": "latest"}}, "exact published version"), | ||
| ], | ||
| ) | ||
| def test_rejects_non_identity_locks( | ||
| tmp_path: Path, | ||
| workers: dict[str, dict[str, str]], | ||
| message: str, | ||
| ) -> None: | ||
| result = run_identity(tmp_path, workers) | ||
|
|
||
| assert result.returncode != 0 | ||
| assert message in result.stderr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🗄️ Data Integrity & Integration | 🟠 Major | 🏗️ Heavy lift
Each matrix job resolves
latestindependently, so the daily data point can mix stack versions.resolve_stack: truemakes every subject/scenario job run its ownharness@latestresolution. If a release publishes while the matrix runs, jobs resolve different versions.collect_harness_e2e_benchmarks.pythen records more than one entry instack_observations, and lines 704-708 and 850-854 fall back to the configured stack. Because the daily lane passes nostack_versionsand nostack_digest, that fallback is empty. The suite and snapshot metadata for that day would then carry no resolved stack version.The reusable workflow already accepts
stack_digest. Resolvinglatestonce in thebuildjob and passing the resolved digest to the matrix would pin the whole day to one stack.🤖 Prompt for AI Agents