chore: make Harness E2E score advisory - #688
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
Next review available in: 57 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe E2E system removes configurable quality-advisory and score-floor settings. Quality-score failures no longer block CI. Empty, hard-gate, and technical failures remain blocking across the runner, workflows, tests, and documentation. ChangesE2E quality gating
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
34a7c78 to
2b37a89
Compare
skill-check — worker0 verified, 52 skipped (no docs/).
Four for four. Nicely done. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/_harness-e2e.yml:
- Around line 434-438: Update the CI gate summary in
.github/workflows/_harness-e2e.yml at lines 434-438 to state that empty reports,
hard-gate failures, and technical failures block CI. Update
harness/tests/e2e/README.md at lines 116-118 to document empty reports as
CI-blocking, and at lines 211-213 include empty reports in each live-model
workflow gate description.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 3983a993-8ba9-4be1-8eed-e9c71c4feebb
📒 Files selected for processing (7)
.github/workflows/_harness-e2e.yml.github/workflows/harness-e2e-daily.yml.github/workflows/harness-e2e-deployed.yml.github/workflows/harness-e2e-main.ymlharness/tests/e2e/README.mdharness/tests/e2e/src/main.rsharness/tests/e2e/src/report.rs
💤 Files with no reviewable changes (3)
- .github/workflows/harness-e2e-main.yml
- .github/workflows/harness-e2e-deployed.yml
- .github/workflows/harness-e2e-daily.yml
has_ci_blocking_failure() also blocks an empty report; state that alongside hard-gate and technical failures in the CI summary and README so operators do not misread a missing result as an advisory quality failure.
Summary
Why
Model scores are probabilistic quality signals. A low score should remain visible for evaluation and trend analysis without independently failing CI.
Validation
cargo fmt --manifest-path harness/Cargo.toml --all -- --checkcargo test --locked --manifest-path harness/Cargo.toml -p harness-e2e— 62 passedcargo clippy --locked --manifest-path harness/Cargo.toml -p harness-e2e --all-targets -- -D warningsSummary by CodeRabbit
Bug Fixes
Documentation
Tests