Skip to content

chore: rename legacy worker dependencies - #678

Merged
guibeira merged 6 commits into
mainfrom
chore/rename-legacy-worker-dependencies
Aug 3, 2026
Merged

chore: rename legacy worker dependencies#678
guibeira merged 6 commits into
mainfrom
chore/rename-legacy-worker-dependencies

Conversation

@guibeira

@guibeira guibeira commented Aug 3, 2026

Copy link
Copy Markdown
Collaborator

Summary

Renames legacy iii-prefixed worker dependencies in worker manifests.

Why

Worker dependency names now use their standalone names consistently.

Validation

  • Official manifest validation for all seven changed workers
  • cargo test --locked for harness (305 tests passed)
  • cargo test --locked for eval remains blocked by an existing iii-helpers version conflict also present on main

Summary by CodeRabbit

  • Documentation
    • Updated worker names and migration guidance to consistently use standalone service terminology.
    • Clarified state storage, provider registration, integration setup, and legacy built-in service requirements across guides and specifications.
    • Updated pub/sub configuration examples and service replacement instructions.
  • Bug Fixes
    • Improved timeout test coverage by using a command that exercises daemon startup behavior.
  • Chores
    • Updated the approval-gate SDK version.

@guibeira guibeira added the no-ticket PR deliberately has no Linear ticket (bump/typo/CI-only) label Aug 3, 2026
@coderabbitai

coderabbitai Bot commented Aug 3, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@guibeira, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 42 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 1efa9e93-5040-4bd7-b5f3-cc8e17b2d8b4

📥 Commits

Reviewing files that changed from the base of the PR and between 82ee89d and e0f794d.

📒 Files selected for processing (4)
  • queue/README.md
  • state/skills/SKILL.md
  • workflow/README.md
  • worktree/src/git/mod.rs
📝 Walkthrough

Walkthrough

The changes align documentation and one worker dependency with standalone names such as state, http, cron, queue, and pubsub. Legacy built-in services are described generically. The Git timeout test now runs git daemon, and iii-sdk is updated to 0.21.8.

Changes

Worker naming alignment

Layer / File(s) Summary
Standalone worker migration terminology
acp/README.md, bridge/..., cron/..., http/..., pubsub/..., queue/..., state/...
Documentation now uses standalone worker names and generic legacy built-in service descriptions.
State worker references
approval-gate/..., docs/..., hermes/..., iii-directory/..., openwiki/..., provider-*/..., slack/..., tech-specs/..., workflow/..., worktree/README.md
References to iii-state and related prefixed providers now use standalone names or state.
Dependency and timeout test alignment
approval-gate/Cargo.toml, worktree/src/git/mod.rs
The SDK version changes to 0.21.8. The timeout test runs git daemon --port=0 --reuseaddr.

Estimated code review effort: 2 (Simple) | ~15 minutes

Possibly related PRs

  • iii-hq/workers#436: Migrates references from the built-in iii-state service to the standalone state worker.
  • iii-hq/workers#464: Relates to migration from iii-queue to the standalone queue worker.
  • iii-hq/workers#465: Updates a worker manifest’s state-worker dependency declaration.

Suggested reviewers: rohitg00, ytallo

Poem

A rabbit checks each worker’s name,
Old built-ins leave the docs the same.
State hops forward, clear and bright,
Git daemon tests the timeout right.
SDK crumbs grow from six to eight.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the primary change: renaming legacy worker dependencies to their standalone names.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/rename-legacy-worker-dependencies

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@vercel

vercel Bot commented Aug 3, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
workers Ready Ready Preview Aug 3, 2026 6:12pm
workers-tech-spec Ready Ready Preview Aug 3, 2026 6:12pm

Request Review

@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

skill-check — worker

0 verified, 52 skipped (no docs/).

Layer Result
structure
vale
ai
render

Four for four. Nicely done.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 4

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@queue/README.md`:
- Around line 190-195: Update the TriggerAction::Enqueue support documentation
in queue/README.md to include the same engine-version guard and QueueEnqueuer
requirement described in queue/skills/SKILL.md, including the
iii::durable::publish fallback until support lands; keep the enqueue path
guidance consistent across both documents.

In `@state/skills/SKILL.md`:
- Line 12: Update the state worker description to clarify that six functions
comprise the core storage surface, while also acknowledging the documented
state::list_keys and internal state::ui-content functions. Keep the existing
worker installation and legacy service guidance unchanged.

In `@workflow/README.md`:
- Line 86: Update the SDK version referenced in the state API sentence to match
the `iii-sdk` version pinned by `workflow/Cargo.toml`, `0.21.6`, or remove the
version qualifier if the documentation should remain version-neutral.

In `@worktree/src/git/mod.rs`:
- Around line 252-258: Update the daemon invocation in run_git_times_out to
obtain a free ephemeral loopback port, pass it explicitly with
--listen=127.0.0.1 and --port, and retain the timeout assertion without relying
on --port=0 or the default port 9418.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 01de5fa8-3f66-49cd-81d3-d0b9f7511649

📥 Commits

Reviewing files that changed from the base of the PR and between 76811e2 and 82ee89d.

⛔ Files ignored due to path filters (2)
  • approval-gate/Cargo.lock is excluded by !**/*.lock
  • provider-kimi/Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (41)
  • acp/README.md
  • approval-gate/Cargo.toml
  • approval-gate/README.md
  • approval-gate/architecture/internals.md
  • bridge/README.md
  • bridge/skills/SKILL.md
  • cron/README.md
  • cron/skills/SKILL.md
  • docs/adr/0001-state-worker-store-location.md
  • docs/sops/configuration.md
  • hermes/README.md
  • http/README.md
  • http/skills/SKILL.md
  • iii-directory/README.md
  • iii-directory/skills/SKILL.md
  • llm-router/README.md
  • openwiki/README.md
  • openwiki/skills/SKILL.md
  • provider-anthropic/README.md
  • provider-claude-code/README.md
  • provider-kimi/README.md
  • provider-kimi/iii.worker.yaml
  • provider-llamacpp/README.md
  • provider-openai-codex/README.md
  • provider-openai/README.md
  • provider-xai/README.md
  • provider-zai/README.md
  • pubsub/README.md
  • pubsub/skills/SKILL.md
  • queue/README.md
  • queue/skills/SKILL.md
  • slack/architecture/README.md
  • slack/architecture/internals.md
  • state/README.md
  • state/skills/SKILL.md
  • tech-specs/2026-06-agentic/approval-gate.md
  • tech-specs/2026-06-agentic/context-manager.md
  • tech-specs/2026-06-agentic/llm-router.md
  • workflow/README.md
  • worktree/README.md
  • worktree/src/git/mod.rs

Comment thread queue/README.md Outdated
Comment thread state/skills/SKILL.md Outdated
Comment thread workflow/README.md Outdated
Comment thread worktree/src/git/mod.rs Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-ticket PR deliberately has no Linear ticket (bump/typo/CI-only)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant