Skip to content

chore(image-resize): bump iii-sdk to =0.12.0-next.1 and clean up legacy files - #62

Merged
andersonleal merged 1 commit into
mainfrom
chore/image-resize-sdk-0.12.0-next.1
Apr 29, 2026
Merged

chore(image-resize): bump iii-sdk to =0.12.0-next.1 and clean up legacy files#62
andersonleal merged 1 commit into
mainfrom
chore/image-resize-sdk-0.12.0-next.1

Conversation

@andersonleal

@andersonleal andersonleal commented Apr 29, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Bump iii-sdk =0.11.3=0.12.0-next.1 (latest published pre-release on crates.io). Worker version 0.1.30.1.4. The channel API used by this worker (register_function_with, ChannelReader/Writer, StreamChannelRef, extract_channel_refs, IIIError) is unchanged in 0.12.0-next.1, so handler/processing code is untouched.
  • Clean up files orphaned by the engine-side protocol-manifest removal: src/manifest.rs, build.rs (its only consumer was the deleted manifest module), the --manifest CLI flag in main.rs, and the matching Dockerfile lines that copied build.rs, ran cargo run -- --manifest > worker.yaml, and copied the unproduced worker.yaml into the runtime image.
  • Drop legacy image-resize/iii.toml. The engine reads iii.toml at the engine's working directory, not at the worker source tree (motia/engine/src/workers/external.rs:120, tagged "legacy" in engine/src/workers/config.rs:194,231). No other worker in this repo carries one.
  • Reformat config.yaml to the flat schema. The engine writes only the inner workers[].config payload to a temp YAML and passes its path via --config (engine/src/workers/external.rs:225-258). The previous envelope form silently failed to parse and main.rs fell back to defaults that happened to match the file's values.

Net diff

```
8 files changed, 11 insertions(+), 102 deletions(-)
image-resize/Cargo.lock | 6 ++---
image-resize/Cargo.toml | 4 +--
image-resize/Dockerfile | 4 ---
image-resize/build.rs | 6 ----- (deleted)
image-resize/config.yaml | 17 +++++-------
image-resize/iii.toml | 2 -- (deleted)
image-resize/src/main.rs | 11 --------
image-resize/src/manifest.rs | 63 -------- (deleted)
```

No source changes to handler, processing, or config logic.

Test plan

  • `cargo build` — clean
  • `cargo test` — 58/58 pass
  • `cargo clippy --all-targets -- -D warnings` — no findings
  • `cargo fmt --all -- --check` — formatted
  • `Cargo.lock` resolves `iii-sdk 0.12.0-next.1`
  • Container build (`docker build` / CI) succeeds end-to-end after `build.rs` and `--manifest` removal
  • Runtime smoke: engine spawns the worker, hands it a flat-schema `--config` temp file, an HTTP/channel resize completes successfully and produces the expected output thumbnail

Summary by CodeRabbit

Release Notes

  • Chores

    • Bumped image-resize to version 0.1.4
    • Updated to SDK version 0.12.0-next.1
  • Refactor

    • Simplified configuration structure to use flat YAML format
    • Removed --manifest CLI option

…cy files

SDK bump:
- iii-sdk =0.11.3 -> =0.12.0-next.1 (latest published pre-release)
- worker 0.1.3 -> 0.1.4
- channel API used by this worker (register_function_with,
  ChannelReader/Writer, StreamChannelRef, extract_channel_refs,
  IIIError) is unchanged in 0.12.0-next.1, so no handler/processing
  changes were needed.

Cleanup of files orphaned by the engine-side protocol-manifest removal:
- src/manifest.rs (dead module)
- build.rs (set TARGET env var only consumed by the deleted manifest.rs)
- --manifest CLI flag in main.rs
- Dockerfile no longer copies build.rs, no longer runs
  `cargo run -- --manifest > worker.yaml`, and no longer copies the
  unproduced worker.yaml into the runtime image.

Other:
- Drop legacy image-resize/iii.toml. The engine reads iii.toml at the
  engine's working directory, not at the worker source tree
  (motia/engine/src/workers/external.rs:120, tagged "legacy" in
  workers/config.rs:194,231). No other worker in the repo carries one.
- Reformat config.yaml to the flat schema. The engine writes only the
  inner config payload to a temp YAML file and passes its path via
  --config (engine/src/workers/external.rs:225-258). The previous
  envelope form silently failed to parse and main.rs fell back to
  defaults that happened to match the file's values.
@coderabbitai

coderabbitai Bot commented Apr 29, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6f51072f-b108-4f01-b359-90aa30d7950e

📥 Commits

Reviewing files that changed from the base of the PR and between f539a7c and 4b80872.

⛔ Files ignored due to path filters (1)
  • image-resize/Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (7)
  • image-resize/Cargo.toml
  • image-resize/Dockerfile
  • image-resize/build.rs
  • image-resize/config.yaml
  • image-resize/iii.toml
  • image-resize/src/main.rs
  • image-resize/src/manifest.rs
💤 Files with no reviewable changes (5)
  • image-resize/Dockerfile
  • image-resize/build.rs
  • image-resize/iii.toml
  • image-resize/src/main.rs
  • image-resize/src/manifest.rs

📝 Walkthrough

Walkthrough

The pull request removes the manifest generation infrastructure from the image-resize worker crate, updates dependencies to iii-sdk 0.12.0-next.1, restructures the configuration from nested to top-level keys, and bumps the crate version to 0.1.4.

Changes

Cohort / File(s) Summary
Dependency & Version Updates
image-resize/Cargo.toml
Bumped image-resize crate version from 0.1.3 to 0.1.4 and updated iii-sdk dependency pin from 0.11.3 to 0.12.0-next.1.
Manifest Generation Removal
image-resize/build.rs, image-resize/src/manifest.rs, image-resize/src/main.rs
Deleted build script, removed manifest.rs module with ModuleManifest struct and build_manifest() function, and removed --manifest CLI flag along with its associated control flow from main.
Configuration Restructuring
image-resize/config.yaml, image-resize/iii.toml
Simplified config.yaml from nested workers[].config structure to root-level keys; removed image-resize worker version pin from iii.toml.
Docker Build Process
image-resize/Dockerfile
Removed build.rs execution step and eliminated the copying of generated worker.yaml artifact into the final image.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested reviewers

  • sergiofilhowz
  • ytallo

🐰 Manifest generation hops away,
Build scripts take their final day,
Config files now stand proud and clean,
Simplest structure ever seen—
Version bumped, SDK renewed, hooray!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main changes: bumping the iii-sdk dependency to a new version and cleaning up legacy files (build.rs, manifest.rs, --manifest flag, iii.toml, and Dockerfile updates).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/image-resize-sdk-0.12.0-next.1

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 60 minutes.

Comment @coderabbitai help to get the list of available commands and usage tips.

@andersonleal
andersonleal merged commit d63ba28 into main Apr 29, 2026
7 checks passed
@andersonleal
andersonleal deleted the chore/image-resize-sdk-0.12.0-next.1 branch April 29, 2026 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant