chore(image-resize): bump iii-sdk to =0.12.0-next.1 and clean up legacy files - #62
Conversation
…cy files SDK bump: - iii-sdk =0.11.3 -> =0.12.0-next.1 (latest published pre-release) - worker 0.1.3 -> 0.1.4 - channel API used by this worker (register_function_with, ChannelReader/Writer, StreamChannelRef, extract_channel_refs, IIIError) is unchanged in 0.12.0-next.1, so no handler/processing changes were needed. Cleanup of files orphaned by the engine-side protocol-manifest removal: - src/manifest.rs (dead module) - build.rs (set TARGET env var only consumed by the deleted manifest.rs) - --manifest CLI flag in main.rs - Dockerfile no longer copies build.rs, no longer runs `cargo run -- --manifest > worker.yaml`, and no longer copies the unproduced worker.yaml into the runtime image. Other: - Drop legacy image-resize/iii.toml. The engine reads iii.toml at the engine's working directory, not at the worker source tree (motia/engine/src/workers/external.rs:120, tagged "legacy" in workers/config.rs:194,231). No other worker in the repo carries one. - Reformat config.yaml to the flat schema. The engine writes only the inner config payload to a temp YAML file and passes its path via --config (engine/src/workers/external.rs:225-258). The previous envelope form silently failed to parse and main.rs fell back to defaults that happened to match the file's values.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (7)
💤 Files with no reviewable changes (5)
📝 WalkthroughWalkthroughThe pull request removes the manifest generation infrastructure from the image-resize worker crate, updates dependencies to Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 0/1 reviews remaining, refill in 60 minutes.Comment |
Summary
iii-sdk=0.11.3→=0.12.0-next.1(latest published pre-release on crates.io). Worker version0.1.3→0.1.4. The channel API used by this worker (register_function_with,ChannelReader/Writer,StreamChannelRef,extract_channel_refs,IIIError) is unchanged in0.12.0-next.1, so handler/processing code is untouched.src/manifest.rs,build.rs(its only consumer was the deleted manifest module), the--manifestCLI flag inmain.rs, and the matching Dockerfile lines that copiedbuild.rs, rancargo run -- --manifest > worker.yaml, and copied the unproducedworker.yamlinto the runtime image.image-resize/iii.toml. The engine readsiii.tomlat the engine's working directory, not at the worker source tree (motia/engine/src/workers/external.rs:120, tagged "legacy" inengine/src/workers/config.rs:194,231). No other worker in this repo carries one.config.yamlto the flat schema. The engine writes only the innerworkers[].configpayload to a temp YAML and passes its path via--config(engine/src/workers/external.rs:225-258). The previous envelope form silently failed to parse andmain.rsfell back to defaults that happened to match the file's values.Net diff
```
8 files changed, 11 insertions(+), 102 deletions(-)
image-resize/Cargo.lock | 6 ++---
image-resize/Cargo.toml | 4 +--
image-resize/Dockerfile | 4 ---
image-resize/build.rs | 6 ----- (deleted)
image-resize/config.yaml | 17 +++++-------
image-resize/iii.toml | 2 -- (deleted)
image-resize/src/main.rs | 11 --------
image-resize/src/manifest.rs | 63 -------- (deleted)
```
No source changes to handler, processing, or config logic.
Test plan
Summary by CodeRabbit
Release Notes
Chores
Refactor
--manifestCLI option