Skip to content

(MOT-3982) fix(approval-gate): align runtime dependency ranges - #483

Merged
ytallo merged 1 commit into
mainfrom
fix/approval-gate-dependency-pins
Jul 12, 2026
Merged

(MOT-3982) fix(approval-gate): align runtime dependency ranges#483
ytallo merged 1 commit into
mainfrom
fix/approval-gate-dependency-pins

Conversation

@ytallo

@ytallo ytallo commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

Installing the current approval-gate worker failed before startup because its dependency graph requested incompatible configuration versions. This aligns approval-gate with the current runtime dependency family so the worker can resolve and start normally.

Technical details

  • Bump iii-state and configuration from ^0.19.0 to ^0.21.3.
  • Add a regression test that keeps approval-gate aligned with iii-directory and Harness core ranges.
  • Verification: 115 scripts tests and 170 approval-gate Rust tests pass.

Fixes MOT-3982

Summary by CodeRabbit

  • Bug Fixes
    • Updated the approval-gate worker to use compatible versions of its shared runtime dependencies.
    • Added regression coverage to help prevent future dependency version mismatches.

@vercel

vercel Bot commented Jul 12, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
workers Ready Ready Preview, Comment Jul 12, 2026 1:33am
workers-tech-spec Ready Ready Preview, Comment Jul 12, 2026 1:33am

Request Review

@github-actions

Copy link
Copy Markdown
Contributor

skill-check — worker

0 verified, 41 skipped (no docs/).

Layer Result
structure
vale
ai
render

Four for four. Nicely done.

@coderabbitai

coderabbitai Bot commented Jul 12, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 4e276f8d-961d-47ea-98f8-33bea655f28b

📥 Commits

Reviewing files that changed from the base of the PR and between 93dcede and bc74d05.

📒 Files selected for processing (2)
  • .github/scripts/tests/test_worker_dependency_compatibility.py
  • approval-gate/iii.worker.yaml

📝 Walkthrough

Walkthrough

Approval-gate dependency requirements for iii-state and configuration were updated to ^0.21.3. A pytest regression test now verifies those requirements match shared ranges from other worker manifests.

Changes

Dependency alignment

Layer / File(s) Summary
Update approval-gate dependency ranges
approval-gate/iii.worker.yaml
Updates iii-state and configuration requirements from ^0.19.0 to ^0.21.3.
Validate shared dependency ranges
.github/scripts/tests/test_worker_dependency_compatibility.py
Adds manifest loading and a regression test comparing approval-gate dependencies with ranges defined by iii-directory and harness.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

  • iii-hq/workers#459: Updates related configuration and iii-state dependency ranges in worker manifests.
  • iii-hq/workers#465: Aligns a worker’s iii-state dependency range to ^0.21.3.

Poem

A bunny checks the ranges twice,
While crates hop in neat device.
Approval-gate now joins the line,
With matching versions, all aligned.
Test carrots grow—what a delight!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: aligning approval-gate runtime dependency ranges.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/approval-gate-dependency-pins

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ytallo
ytallo merged commit 60bb74f into main Jul 12, 2026
15 checks passed
@ytallo
ytallo deleted the fix/approval-gate-dependency-pins branch July 12, 2026 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant