(MOT-3929) fix(provider-anthropic): surface adaptive thinking by default on thinking-capable models - #462
Conversation
…ult on thinking-capable models With no explicit thinking_level, build_thinking_config always returned config: None, so thinking-capable models (Sonnet 4.6+, Opus 4.7+, Fable/Mythos 5) never got adaptive reasoning unless the caller asked for a level. provider-xai surfaces reasoning by default with no explicit level; this brings provider-anthropic to parity. Gated on supports_thinking == Some(true) specifically, so an unknown or explicitly non-thinking model never gets the implicit default and can't 400. Cargo.lock churn across the other providers/approval-gate is from the harness v1.1.12 bump (iii-sdk/iii-helpers version resolution).
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
skill-check — worker0 verified, 41 skipped (no docs/).
Four for four. Nicely done. |
|
Warning Review limit reached
Next review available in: 49 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughModified ChangesAdaptive Thinking Default Behavior
Estimated code review effort: 1 (Trivial) | ~5 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…lippy) Pre-existing clippy::collapsible_if failure from #460, unrelated to this PR's change but blocking CI on this branch since it touches provider-openai-codex/Cargo.lock. No behavior change.
install.iii.dev's install.sh calls the GitHub API to resolve the release; unauthenticated it's capped at 60/hr and intermittently fails "interface boot smoke" jobs across workers (hit twice on this PR alone). The script's own error message points at $GITHUB_TOKEN, so export the job's token to lift the cap to the authenticated rate.
Summary
thinking_level,provider-anthropicalways sentconfig: None— thinking-capable models (Sonnet 4.6+, Opus 4.7+, Fable/Mythos 5) never got adaptive thinking unless the caller explicitly requested a level.provider-xaisurfaces reasoning by default with no explicit level; this bringsprovider-anthropicto parity.build_thinking_confignow requestsADAPTIVE(server default effort, nooutput_config) when no level is given and the model'ssupports_thinkingis explicitlySome(true). Unknown (None) or explicitlySome(false)models keep the old behavior, so the implicit default can never 400 a non-thinking or unknown model.Cargo.lockchurn acrossapproval-gate/other providers is from the harness v1.1.12 bump (iii-sdk/iii-helpersversion resolution), not a functional change.Test plan
cargo test thinkinginprovider-anthropic(14 passed)absent_level_defaults_on_for_thinking_models,absent_level_stays_off_without_thinking_supporthttps://linear.app/motia/issue/MOT-3929/provider-anthropic-surface-adaptive-thinking-by-default-on-thinking
Summary by CodeRabbit
Bug Fixes
Tests