Skip to content

chore(database): bump iii-sdk to 0.20.0 - #349

Merged
guibeira merged 1 commit into
mainfrom
chore/sdk-0.20-database
Jun 26, 2026
Merged

chore(database): bump iii-sdk to 0.20.0#349
guibeira merged 1 commit into
mainfrom
chore/sdk-0.20-database

Conversation

@guibeira

@guibeira guibeira commented Jun 26, 2026

Copy link
Copy Markdown
Collaborator

Bump iii-sdk 0.16.0-next.2 → 0.20.0 + migrate observability to iii-helpers (iii-observability removed) per https://iii.dev/docs/upgrading/from-0-19-x.md. Build, fmt, clippy, tests green (208 tests); surface parity (12 functions + 1 trigger) 1:1. No import aliases.

Summary by CodeRabbit

  • Bug Fixes

    • Improved error handling across database operations and configuration flows for more consistent failures.
    • Kept transaction, query, and trigger behavior unchanged while updating internal error translation.
  • Chores

    • Updated database dependencies to newer compatible versions.
    • Replaced legacy observability wiring with the current shared helper setup across tests and runtime support.

@vercel

vercel Bot commented Jun 26, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
workers Ready Ready Preview, Comment Jun 26, 2026 5:21pm
workers-tech-spec Ready Ready Preview, Comment Jun 26, 2026 5:21pm

Request Review

@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b60faa00-9b3d-48c0-81c1-4345b47a42cb

📥 Commits

Reviewing files that changed from the base of the PR and between 6346d06 and b179013.

⛔ Files ignored due to path filters (1)
  • database/Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (18)
  • database/Cargo.toml
  • database/src/configuration.rs
  • database/src/error.rs
  • database/src/handlers/begin_transaction.rs
  • database/src/handlers/commit_transaction.rs
  • database/src/handlers/execute.rs
  • database/src/handlers/list_databases.rs
  • database/src/handlers/mod.rs
  • database/src/handlers/prepare.rs
  • database/src/handlers/query.rs
  • database/src/handlers/rollback_transaction.rs
  • database/src/handlers/run_statement.rs
  • database/src/handlers/transaction.rs
  • database/src/handlers/transaction_execute.rs
  • database/src/main.rs
  • database/src/transaction.rs
  • database/src/triggers/handler.rs
  • database/tests/integration.rs

📝 Walkthrough

Walkthrough

The database crate upgrades to iii-sdk 0.20 and iii-helpers. Configuration and trigger code now use IIIClient and Error, DbError and function registrations map through the new error type, and logger imports and test state builders switch to the new observability helper.

Changes

Database SDK migration

Layer / File(s) Summary
Observability import swap
database/Cargo.toml, database/src/main.rs, database/src/transaction.rs, database/src/handlers/*.rs, database/tests/integration.rs
iii-sdk and observability dependencies move to the newer pinned versions, and logger imports and Logger::new() calls switch to iii_helpers::observability across runtime code and tests.
Configuration client migration
database/src/configuration.rs
Configuration registration, fetch, helper, and hot-reload code switches from III/IIIError to IIIClient/Error.
Error and registration conversion
database/src/error.rs, database/src/triggers/handler.rs, database/src/main.rs
DbError conversions, trigger handler errors, and database function registration error mapping now use iii_sdk::errors::Error.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

  • iii-hq/workers#328: Also migrates iii-sdk 0.20 APIs from III/IIIError to IIIClient/iii_sdk::errors::Error.
  • iii-hq/workers#338: Also combines iii-sdk 0.20 client/error updates with the iii-observability to iii-helpers swap.
  • iii-hq/workers#343: Also changes configuration and registration code to use IIIClient, Error, and new map_err conversions.

Suggested reviewers

  • sergiofilhowz

Poem

Hoppity-hop, the database gleams,
With helper logs and cleaner streams.
My whiskers twitch at error's new attire,
And config paws now leap a little higher.
🐇✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: upgrading the database crate to iii-sdk 0.20.0.
Docstring Coverage ✅ Passed Docstring coverage is 96.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/sdk-0.20-database

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

skill-check — worker

0 verified, 27 skipped (no docs/).

Layer Result
structure
vale
ai
render

Four for four. Nicely done.

@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown

Caution

Failed to replace (edit) comment. This is likely due to insufficient permissions or the comment being deleted.

Error details
{"name":"HttpError","status":500,"request":{"method":"PATCH","url":"https://api.github.com/repos/iii-hq/workers/issues/comments/4811803786","headers":{"accept":"application/vnd.github.v3+json","user-agent":"octokit.js/0.0.0-development octokit-core.js/7.0.6 Node.js/24","content-type":"application/json; charset=utf-8"},"body":{"body":"<!-- This is an auto-generated comment: summarize by coderabbit.ai -->\n<!-- review_stack_entry_start -->\n\n[![Review Change Stack](https://storage.googleapis.com/coderabbit_public_assets/review-stack-in-coderabbit-ui.svg)](https://app.coderabbit.ai/change-stack/iii-hq/workers/pull/349?utm_source=github_walkthrough&utm_medium=github&utm_campaign=change_stack)\n\n<!-- review_stack_entry_end -->\n<!-- This is an auto-generated comment: review in progress by coderabbit.ai -->\n\n> [!NOTE]\n> Currently processing new changes in this PR. This may take a few minutes, please wait...\n> \n> <details>\n> <summary>⚙️ Run configuration</summary>\n> \n> **Configuration used**: Organization UI\n> \n> **Review profile**: CHILL\n> \n> **Plan**: Pro\n> \n> **Run ID**: `b60faa00-9b3d-48c0-81c1-4345b47a42cb`\n> \n> </details>\n> \n> <details>\n> <summary>📥 Commits</summary>\n> \n> Reviewing files that changed from the base of the PR and between 6346d065aa7d6b9092fdc60f57c79e34d41ba293 and b179013e9147a8875508c783d78bcd169ebd9ad6.\n> \n> </details>\n> \n> <details>\n> <summary>⛔ Files ignored due to path filters (1)</summary>\n> \n> * `database/Cargo.lock` is excluded by `!**/*.lock`\n> \n> </details>\n> \n> <details>\n> <summary>📒 Files selected for processing (18)</summary>\n> \n> * `database/Cargo.toml`\n> * `database/src/configuration.rs`\n> * `database/src/error.rs`\n> * `database/src/handlers/begin_transaction.rs`\n> * `database/src/handlers/commit_transaction.rs`\n> * `database/src/handlers/execute.rs`\n> * `database/src/handlers/list_databases.rs`\n> * `database/src/handlers/mod.rs`\n> * `database/src/handlers/prepare.rs`\n> * `database/src/handlers/query.rs`\n> * `database/src/handlers/rollback_transaction.rs`\n> * `database/src/handlers/run_statement.rs`\n> * `database/src/handlers/transaction.rs`\n> * `database/src/handlers/transaction_execute.rs`\n> * `database/src/main.rs`\n> * `database/src/transaction.rs`\n> * `database/src/triggers/handler.rs`\n> * `database/tests/integration.rs`\n> \n> </details>\n> \n> ```ascii\n>  _____________________________________________________________________________________________________________\n> < Perfection is achieved, not when there is nothing more to add, but when there is nothing left to take away. >\n>  -------------------------------------------------------------------------------------------------------------\n>   \\\n>    \\   (\\__/)\n>        (•ㅅ•)\n>        /   づ\n> ```\n\n<!-- end of auto-generated comment: review in progress by coderabbit.ai -->\n\n<!-- finishing_touch_checkbox_start -->\n\n<details>\n<summary>✨ Finishing Touches</summary>\n\n<details>\n<summary>📝 Generate docstrings</summary>\n\n- [ ] <!-- {\"checkboxId\": \"7962f53c-55bc-4827-bfbf-6a18da830691\"} --> Create stacked PR\n- [ ] <!-- {\"checkboxId\": \"3e1879ae-f29b-4d0d-8e06-d12b7ba33d98\"} --> Commit on current branch\n\n</details>\n<details>\n<summary>🧪 Generate unit tests (beta)</summary>\n\n- [ ] <!-- {\"checkboxId\": \"f47ac10b-58cc-4372-a567-0e02b2c3d479\", \"radioGroupId\": \"utg-output-choice-group-unknown_comment_id\"} -->   Create PR with unit tests\n- [ ] <!-- {\"checkboxId\": \"6ba7b810-9dad-11d1-80b4-00c04fd430c8\", \"radioGroupId\": \"utg-output-choice-group-unknown_comment_id\"} -->   Commit unit tests in branch `chore/sdk-0.20-database`\n\n</details>\n\n</details>\n\n<!-- finishing_touch_checkbox_end -->\n<!-- tips_start -->\n\n---\n\nThanks for using [CodeRabbit](https://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=iii-hq/workers&utm_content=349)! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.\n\n<details>\n<summary>❤️ Share</summary>\n\n- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai)\n- [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai)\n- [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai)\n- [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)\n\n</details>\n\n\n<sub>Comment `@coderabbitai help` to get the list of available commands.</sub>\n\n<!-- tips_end -->"},"request":{"retryCount":3,"signal":{},"retries":3,"retryAfter":16}}}

@guibeira
guibeira merged commit 17c6128 into main Jun 26, 2026
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant