Skip to content

fix(codex): typed response schemas + strip the $schema meta-ref - #323

Merged
rohitg00 merged 1 commit into
mainfrom
fix/codex-schema-gates
Jun 25, 2026
Merged

fix(codex): typed response schemas + strip the $schema meta-ref#323
rohitg00 merged 1 commit into
mainfrom
fix/codex-schema-gates

Conversation

@rohitg00

Copy link
Copy Markdown
Contributor

Pre-empts the two registry gates pi hit (#317, #319), so codex can be released. codex declares only request_format and emits $schema via schemars, so it would fail both gates on its next release.

  • Typed response_format on every codex:: function + a typed request/response on codex::on-config-change.
  • schema_value now strips the $schema key schemars stamps at the root of every request schema, which the registry publish validator cannot resolve.

cargo fmt clean, clippy clean (-D warnings), all tests pass.

Pre-empt the two registry gates pi hit. Add a typed response_format to
every codex:: function (and a typed request/response on
codex::on-config-change), and strip the $schema key schemars stamps at
the root of every request schema, which the registry publish validator
cannot resolve. fmt + clippy clean, tests pass.
@vercel

vercel Bot commented Jun 24, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
workers Ready Ready Preview, Comment Jun 24, 2026 9:35am

Request Review

@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@rohitg00, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 59 minutes and 58 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: bda9019a-f9b0-4933-8b0f-78dbf7b718f3

📥 Commits

Reviewing files that changed from the base of the PR and between 6b8c600 and eed6c46.

📒 Files selected for processing (2)
  • codex/src/configuration.rs
  • codex/src/functions/mod.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/codex-schema-gates

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

skill-check — worker

0 verified, 25 skipped (no docs/).

Layer Result
structure
vale
ai
render

Four for four. Nicely done.

@rohitg00
rohitg00 merged commit e234612 into main Jun 25, 2026
12 checks passed
@rohitg00
rohitg00 deleted the fix/codex-schema-gates branch June 25, 2026 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant