fix(claude-code): typed response schemas + strip the $schema meta-ref - #322
Conversation
Pre-empt the two registry gates pi hit. Declare a typed response_format on every claude:: function (and a typed request/null response on claude::on-config-change), and add a jsonSchema() helper that strips the draft-2020-12 $schema key z.toJSONSchema stamps at the root, which the registry publish validator cannot resolve. runtimeJsonSchema strips it too. 75 tests pass.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
skill-check — worker0 verified, 25 skipped (no docs/).
Four for four. Nicely done. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthrough
ChangesRegistry Schema Metadata
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Pre-empts the two registry gates pi hit (#317, #319), so claude-code can be released. claude-code declares only
request_formatand emits$schemavia z.toJSONSchema, so it would fail both gates on its next release.response_formaton every claude:: function + a typed request / null response onclaude::on-config-change.jsonSchema()helper strips the draft-2020-12$schemakey from every request and response format;runtimeJsonSchemastrips it too.typecheck clean, lint clean, 75 tests pass.
Summary by CodeRabbit