fix(pi): publish typed response schemas and strip the $schema meta-ref - #318
fix(pi): publish typed response schemas and strip the $schema meta-ref#318rohitg00 wants to merge 3 commits into
Conversation
CI's worker-interface gate rejects untyped (AnyValue/empty) response schemas. Declare a typed response_format on every pi:: function via z.toJSONSchema, and give pi::on-config-change a typed request_format plus a null response_format. All schemas satisfy the collector's typed-keyword check; 69 tests still pass.
Replace the open z.record(z.string(), z.unknown()) in the status and sessions::list response schemas with a concrete SessionRecordSchema, so the published nested schema carries the real record contract instead of an empty additionalProperties node.
The registry publish validator has no draft-2020-12 meta-schema registered, so the $schema key z.toJSONSchema stamps at the root fails publish with 'no schema with key or ref ...draft/2020-12/schema'. Add a jsonSchema() helper that strips the root $schema from every request and response format, and do the same in runtimeJsonSchema. Schemas stay typed; 69 tests pass.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
More reviews will be available in 39 minutes and 39 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses rolling per-developer review limits. Reviews become available again as older review attempts age out of the rolling limit window. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
skill-check — worker0 verified, 25 skipped (no docs/).
Four for four. Nicely done. |
1 participant
pi merged in #314 but cannot publish: the worker-interface CI gate and the registry validator both reject its schemas.
What this fixes
response_schemais the empty/AnyValue node. Every pi:: function declared onlyrequest_format, soresponse_schemawas untyped. Declares a typedresponse_formaton all eight functions pluspi::on-config-change.$schemameta-ref — the registry publish validator has no draft-2020-12 meta-schema registered, so the$schemakeyz.toJSONSchemastamps at the root fails publish withno schema with key or ref ...draft/2020-12/schema. AjsonSchema()helper strips the root$schemafrom every request and response format, andruntimeJsonSchemadoes the same.Status and sessions::list responses carry a concrete
SessionRecordschema rather than an open record, so the published nested schema is fully typed.Validation
$schemakey.Note for the team
Both gates are new. claude-code and codex declare only
request_formatand do not strip$schema, so both will fail the same two gates on their next release. They are grandfathered until then.