Skip to content

refactor(lsp-vscode): rename extension module and consume lsp binary - #275

Merged
guibeira merged 2 commits into
mainfrom
refactor/rename-lsp-vscode
Jun 17, 2026
Merged

refactor(lsp-vscode): rename extension module and consume lsp binary#275
guibeira merged 2 commits into
mainfrom
refactor/rename-lsp-vscode

Conversation

@guibeira

@guibeira guibeira commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

Summary

Renames the VS Code extension source/release module from iii-lsp-vscode to lsp-vscode while preserving the published extension package identity as iii-lsp.

Changes

  • Moves iii-lsp-vscode/ to lsp-vscode/.
  • Keeps package.json name: "iii-lsp" and the iii-lsp.* settings namespace for Marketplace/OpenVSX continuity.
  • Points the installer at the new binary release lsp/v0.1.3 and the new lsp-* release assets.
  • Updates CI discovery, Create Tag options, and the extension release workflow to use lsp-vscode/v* tags.
  • Aligns the extension manifest version with the latest published extension release (0.2.6) so the next lsp-vscode patch release becomes 0.2.7.
  • Updates README references from iii-lsp-vscode to lsp-vscode and documents that the package name remains iii-lsp.

Validation

  • docker build -t lsp-vscode-dev .
  • docker run --rm -u "$(id -u):$(id -g)" -e npm_config_cache=/tmp/npm-cache -v "$PWD:/workspace" -w /workspace lsp-vscode-dev npm ci
  • docker run --rm -u "$(id -u):$(id -g)" -e npm_config_cache=/tmp/npm-cache -v "$PWD:/workspace" -w /workspace lsp-vscode-dev npm test
  • docker run --rm -u "$(id -u):$(id -g)" -e npm_config_cache=/tmp/npm-cache -v "$PWD:/workspace" -w /workspace lsp-vscode-dev npm run package:check
  • python3 .github/scripts/discover_changed_workers.py --base origin/main --head HEAD
  • git diff --check origin/main..HEAD

Summary by CodeRabbit

  • New Features

    • Updated extension version to 0.2.6 with server binary v0.1.3.
  • Documentation

    • Updated setup instructions and development guidance to reflect reorganized project structure and naming conventions.
  • Chores

    • Reorganized project directories and updated CI/CD workflows, build configuration, and test expectations accordingly.

@vercel

vercel Bot commented Jun 16, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
workers Ready Ready Preview, Comment Jun 17, 2026 11:07am

Request Review

@coderabbitai

coderabbitai Bot commented Jun 16, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@guibeira, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 48 minutes and 1 second. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: dbce8f81-257f-4576-b55e-831b8d9196d8

📥 Commits

Reviewing files that changed from the base of the PR and between a2838eb and fd200a5.

📒 Files selected for processing (1)
  • lsp-vscode/extension.js
📝 Walkthrough

Walkthrough

The PR renames the VS Code extension package from iii-lsp-vscode to lsp-vscode across all CI workflows, scripts, Makefiles, and documentation. Alongside the rename, installer.js bumps SERVER_VERSION to 0.1.3, renames downloaded binary assets from iii-lsp to lsp, and extracts a shared CONFIG_SECTION constant used by both installer.js and extension.js. The extension manifest version is bumped from 0.1.0 to 0.2.6.

Changes

iii-lsp-vscode → lsp-vscode Rename and Version Bump

Layer / File(s) Summary
Installer constants, binary naming, and CONFIG_SECTION
lsp-vscode/installer.js, lsp-vscode/extension.js
Adds CONFIG_SECTION = 'iii-lsp' constant, bumps SERVER_VERSION to 0.1.3, renames archive/binary/checksum assets from iii-lsp-* to lsp-*, updates ensureServerBinary and activate() to use CONFIG_SECTION instead of a hard-coded string, and exports the constant.
Extension manifest version and metadata
lsp-vscode/package.json
Bumps extension version from 0.1.0 to 0.2.6, updates iii-lsp.serverPath description to reference the lsp binary, adds lsp-vscode keyword, and changes repository.directory to lsp-vscode.
Installer test suite updated for new naming and version
lsp-vscode/test/installer.test.mjs
Updates all installer tests to expect lsp-* archive/binary names, lsp/lsp.exe executables, updated error text, new SERVER_VERSION/RELEASE_TAG constants, and lsp-* download/sha256 URLs.
CI, create-tag, and release workflow renames
.github/scripts/discover_changed_workers.py, .github/workflows/ci.yml, .github/workflows/create-tag.yml, .github/workflows/release-lsp-vscode.yml
Renames the CI job and change-detection constant to lsp-vscode. Updates create-tag worker input and manifest-discovery condition. Updates release workflow tag pattern, version prefix stripping, publish working-directory, notice messages, and GitHub Release name/VSIX path.
README and developer docs
README.md, lsp/README.md, lsp-vscode/README.md, lsp-vscode/AGENTS.md, lsp-vscode/Makefile
Updates root README module table, lsp/README.md extension references, lsp-vscode/README.md directory/binary/command instructions, AGENTS.md Docker image and commands, and Makefile IMAGE default to lsp-vscode-dev.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

  • iii-hq/workers#17: Introduced the original iii-lsp-vscode CI jobs and release pipeline that this PR renames to lsp-vscode.
  • iii-hq/workers#240: Previously updated SERVER_VERSION in iii-lsp-vscode/installer.js; this PR applies an equivalent bump in the renamed lsp-vscode/installer.js.
  • iii-hq/workers#265: Updated iii-lsp settings namespace and server binary resolution in the extension, directly overlapping with the CONFIG_SECTION and serverPath handling changes in this PR.

Suggested reviewers

  • sergiofilhowz

🐇 A directory once named with three i's,
Hops forward now under cleaner skies.
lsp-vscode it stands, bright and lean,
No more iii- prefix to be seen!
The rabbit cheers: "Rename complete!" 🎉

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 11.11% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the primary change: renaming the extension module from iii-lsp-vscode to lsp-vscode and updating it to consume the new lsp binary.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor/rename-lsp-vscode

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

skill-check — worker

0 verified, 22 skipped (no docs/).

Layer Result
structure
vale
ai
render

Four for four. Nicely done.

@guibeira
guibeira marked this pull request as ready for review June 17, 2026 10:55

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@lsp-vscode/extension.js`:
- Around line 6-9: The CONFIG_SECTION constant is currently defined locally in
extension.js but is already exported from installer.js, causing unnecessary
duplication. Remove the local CONFIG_SECTION constant definition and instead add
it to the existing destructured import from "./installer" alongside
ensureServerBinary. This will eliminate the duplication and ensure a single
source of truth for the configuration section name.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: af57bf08-6266-4d5d-b116-bfae2b80aee4

📥 Commits

Reviewing files that changed from the base of the PR and between 5f220da and a2838eb.

⛔ Files ignored due to path filters (3)
  • lsp-vscode/images/iii.png is excluded by !**/*.png
  • lsp-vscode/images/lsp.gif is excluded by !**/*.gif
  • lsp-vscode/package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (16)
  • .github/scripts/discover_changed_workers.py
  • .github/workflows/ci.yml
  • .github/workflows/create-tag.yml
  • .github/workflows/release-lsp-vscode.yml
  • README.md
  • lsp-vscode/.gitignore
  • lsp-vscode/.vscodeignore
  • lsp-vscode/AGENTS.md
  • lsp-vscode/Dockerfile
  • lsp-vscode/Makefile
  • lsp-vscode/README.md
  • lsp-vscode/extension.js
  • lsp-vscode/installer.js
  • lsp-vscode/package.json
  • lsp-vscode/test/installer.test.mjs
  • lsp/README.md

Comment thread lsp-vscode/extension.js Outdated
@guibeira
guibeira merged commit 758a66c into main Jun 17, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant