refactor(lsp-vscode): rename extension module and consume lsp binary - #275
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Warning Review limit reached
More reviews will be available in 48 minutes and 1 second. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe PR renames the VS Code extension package from Changesiii-lsp-vscode → lsp-vscode Rename and Version Bump
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
skill-check — worker0 verified, 22 skipped (no docs/).
Four for four. Nicely done. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@lsp-vscode/extension.js`:
- Around line 6-9: The CONFIG_SECTION constant is currently defined locally in
extension.js but is already exported from installer.js, causing unnecessary
duplication. Remove the local CONFIG_SECTION constant definition and instead add
it to the existing destructured import from "./installer" alongside
ensureServerBinary. This will eliminate the duplication and ensure a single
source of truth for the configuration section name.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: af57bf08-6266-4d5d-b116-bfae2b80aee4
⛔ Files ignored due to path filters (3)
lsp-vscode/images/iii.pngis excluded by!**/*.pnglsp-vscode/images/lsp.gifis excluded by!**/*.giflsp-vscode/package-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (16)
.github/scripts/discover_changed_workers.py.github/workflows/ci.yml.github/workflows/create-tag.yml.github/workflows/release-lsp-vscode.ymlREADME.mdlsp-vscode/.gitignorelsp-vscode/.vscodeignorelsp-vscode/AGENTS.mdlsp-vscode/Dockerfilelsp-vscode/Makefilelsp-vscode/README.mdlsp-vscode/extension.jslsp-vscode/installer.jslsp-vscode/package.jsonlsp-vscode/test/installer.test.mjslsp/README.md
Summary
Renames the VS Code extension source/release module from
iii-lsp-vscodetolsp-vscodewhile preserving the published extension package identity asiii-lsp.Changes
iii-lsp-vscode/tolsp-vscode/.package.jsonname: "iii-lsp"and theiii-lsp.*settings namespace for Marketplace/OpenVSX continuity.lsp/v0.1.3and the newlsp-*release assets.lsp-vscode/v*tags.0.2.6) so the nextlsp-vscodepatch release becomes0.2.7.iii-lsp-vscodetolsp-vscodeand documents that the package name remainsiii-lsp.Validation
docker build -t lsp-vscode-dev .docker run --rm -u "$(id -u):$(id -g)" -e npm_config_cache=/tmp/npm-cache -v "$PWD:/workspace" -w /workspace lsp-vscode-dev npm cidocker run --rm -u "$(id -u):$(id -g)" -e npm_config_cache=/tmp/npm-cache -v "$PWD:/workspace" -w /workspace lsp-vscode-dev npm testdocker run --rm -u "$(id -u):$(id -g)" -e npm_config_cache=/tmp/npm-cache -v "$PWD:/workspace" -w /workspace lsp-vscode-dev npm run package:checkpython3 .github/scripts/discover_changed_workers.py --base origin/main --head HEADgit diff --check origin/main..HEADSummary by CodeRabbit
New Features
Documentation
Chores