fix(ci): migrate publish pipeline to engine::triggers::list - #219
Conversation
The engine renamed trigger-type listing from engine::trigger-types::list to engine::triggers::list with a triggers response key. Update the publish workflow and payload normalizer so worker trigger collection does not silently produce an empty triggers array. Co-authored-by: Cursor <cursoragent@cursor.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthroughThis PR updates the trigger type data collection pipeline to use a new engine endpoint. The workflow baseline generation and collector script both migrate from ChangesTrigger data source migration to new engine endpoint
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
skill-check — worker0 verified, 14 skipped (no docs/).
Four for four. Nicely done. |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/_publish-registry.yml (1)
109-116: Adjust:engine::triggers::listalready matches the expected per-item schemaThe repo’s
engine::triggers::listintrospection/parsers model includesid,trigger_request_format, andcall_request_format, matching whatbuild_publish_payload.normalize_worker_interfaceconsumes from each item under the top-leveltriggerskey—so the baseline diff/normalization shouldn’t silently drop triggers due to field-shape changes. The only leftover cleanup is renamingtrigger-types-baseline.json(and the step title) since it snapshots trigger instances rather than trigger types.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/_publish-registry.yml around lines 109 - 116, The baseline step is misnamed: `engine::triggers::list` already outputs items matching the schema consumed by build_publish_payload.normalize_worker_interface (fields like id, trigger_request_format, call_request_format), so update the workflow step name and output file to reflect that it snapshots trigger instances, not trigger types; specifically rename the step title from "Snapshot engine trigger types baseline" and the output file trigger-types-baseline.json to something like trigger-instances-baseline.json (and update any downstream references) while leaving the `iii trigger 'engine::triggers::list' --json ...` invocation unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In @.github/workflows/_publish-registry.yml:
- Around line 109-116: The baseline step is misnamed: `engine::triggers::list`
already outputs items matching the schema consumed by
build_publish_payload.normalize_worker_interface (fields like id,
trigger_request_format, call_request_format), so update the workflow step name
and output file to reflect that it snapshots trigger instances, not trigger
types; specifically rename the step title from "Snapshot engine trigger types
baseline" and the output file trigger-types-baseline.json to something like
trigger-instances-baseline.json (and update any downstream references) while
leaving the `iii trigger 'engine::triggers::list' --json ...` invocation
unchanged.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 7b10b057-640a-4d55-86be-07676b4056b9
📒 Files selected for processing (3)
.github/scripts/build_publish_payload.py.github/scripts/collect_worker_interface.py.github/workflows/_publish-registry.yml
Summary
engine::triggers::listinstead of the deprecatedengine::trigger-types::list.build_publish_payload.pyto read the newtriggersresponse key when diffing baseline vs current trigger types for registry publishing.Test plan
normalize_worker_interfacewith the new{ "triggers": [...] }response shapeMade with Cursor
Summary by CodeRabbit