feat: architecture docs - #155
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthroughThis PR expands documentation coverage for the harness-node system by publishing comprehensive architecture and per-worker documentation into the repository, enabling git tracking. It includes system design diagrams, worker interface catalogs, and a refinement to the agent's plan-mode system prompt. ChangesHarness-Node Documentation and System Prompt
🎯 2 (Simple) | ⏱️ ~10 minutes Possibly Related PRs
Suggested Reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
skill-check — worker0 verified, 10 skipped (no docs/).
Three for three. Nicely done. |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@harness-node/docs/workers/context-compaction.md`:
- Line 17: The doc mixes British and American spellings—replace all British
variants with American ones: change "summarises" to "summarizes" and "summarise"
to "summarize" across the file (notably the occurrence at the sentence
containing "messages, summarises, the older prefix..." and the other instances
noted), ensure existing American usage like "SUMMARIZER" and "summarize.ts"
remains unchanged, and run a quick grep for "summaris" to catch any remaining
British forms and update them to the American spelling.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 81036e8f-c88e-4c13-9492-998e1d851015
📒 Files selected for processing (15)
.gitignoreharness-node/README.mdharness-node/docs/architecture.mdharness-node/docs/workers/approval-gate.mdharness-node/docs/workers/auth-credentials.mdharness-node/docs/workers/context-compaction.mdharness-node/docs/workers/harness.mdharness-node/docs/workers/hook-fanout.mdharness-node/docs/workers/llm-budget.mdharness-node/docs/workers/models-catalog.mdharness-node/docs/workers/provider-anthropic.mdharness-node/docs/workers/provider-openai.mdharness-node/docs/workers/session.mdharness-node/docs/workers/turn-orchestrator.mdharness-node/src/turn-orchestrator/system-prompt.ts
💤 Files with no reviewable changes (1)
- .gitignore
| cache_read`, excluding `cache_write`) crosses the configured threshold, | ||
| it acquires a per-session single-writer lease, asks `session-tree` for | ||
| the active path, splits off the last `COMPACT_KEEP_RECENT_TURNS` | ||
| messages, summarises the older prefix via the configured provider's |
There was a problem hiding this comment.
Standardize spelling: use American English consistently.
The document mixes British English ("summarises", "summarise") with American English ("summarizer", "summarize"). Pick one variant and use it throughout—American English is more common in technical documentation.
📝 Suggested standardization
Change all occurrences to American spelling:
- Line 17: "summarises" → "summarizes"
- Line 60: "summarise" → "summarize"
- Lines 80-81: Keep "SUMMARIZER" (already American)
- Line 99: Keep "summarize.ts" (already American)
Also applies to: 60-60, 80-81, 99-99
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@harness-node/docs/workers/context-compaction.md` at line 17, The doc mixes
British and American spellings—replace all British variants with American ones:
change "summarises" to "summarizes" and "summarise" to "summarize" across the
file (notably the occurrence at the sentence containing "messages, summarises,
the older prefix..." and the other instances noted), ensure existing American
usage like "SUMMARIZER" and "summarize.ts" remains unchanged, and run a quick
grep for "summaris" to catch any remaining British forms and update them to the
American spelling.
Summary by CodeRabbit
Documentation
Chores