Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deprecated pytest hook arg #519

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

glatterf42
Copy link
Member

@glatterf42 glatterf42 commented Mar 4, 2024

Our whole CI is failing (same for several downstream projects) because one of the pytest hooks here is using a deprecated argument: startdir has been replaced by start_path. This was kindly pointed out in pytest-dev/pytest#12061, though I have to admit even with the linked deprecation changelog, this might not have been entirely clear to me. After all, the changelog says the hook is now receiving 'additional arguments', not 'changed arguments'. Either way, this PR includes the fix.

Should we update the release notes since other projects might have seen failures due to the hook arguments being out of date? If so, we haven't received an issue yet.

How to review

  • Read the diff and note that the CI checks all pass.

PR checklist

  • Continuous integration checks all ✅
  • [ ] Add or expand tests; coverage checks both ✅ Just an internal change
  • [ ] Add, expand, or update documentation. Just an internal change
  • [ ] Update release notes. Just an internal change

@glatterf42 glatterf42 self-assigned this Mar 4, 2024
@glatterf42 glatterf42 added bug ci Continuous integration labels Mar 4, 2024
@glatterf42 glatterf42 added this to the 3.9 milestone Mar 4, 2024
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.9%. Comparing base (049689a) to head (ba6d7af).

Additional details and impacted files
@@          Coverage Diff          @@
##            main    #519   +/-   ##
=====================================
  Coverage   98.9%   98.9%           
=====================================
  Files         44      44           
  Lines       4795    4795           
=====================================
  Hits        4743    4743           
  Misses        52      52           
Files Coverage Δ
ixmp/testing/__init__.py 95.9% <100.0%> (ø)

Copy link
Member

@khaeru khaeru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As noted in Slack, this is ready to merge.

The Windows job failures are acceptable: they occur due to an unrelated issue with the third-party codecov/codecov-action that has also been seen in scheduled (non-PR) runs. The test suite passes, but then the coverage upload stalls, in turn stalling the overall job.

Since this issue with pytest >= 8.1 affects scheduled and PR runs downstream (e.g. iiasa/message_ix#784), we can merge and addressing that issue separately.

@glatterf42 glatterf42 merged commit 809e28a into iiasa:main Mar 4, 2024
16 of 21 checks passed
@glatterf42 glatterf42 deleted the fix/pytest-hook branch March 4, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug ci Continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants