Adding support for Silex 2 #55
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntents before parsing; passing a filename is being deprecated
…gistered as a syntax error, which ConfigServiceProvider users won't be expecting and likely won't be concerned about.
|
Just an FYI: This also removes support for PHP 5.3 and 5.4 |
|
Seems to do the job for me 👍 |
chuanma
reviewed
Oct 19, 2016
|
|
||
| use Pimple\Container; | ||
| use Pimple\ServiceProviderInterface; | ||
| use Silex\Application; |
There was a problem hiding this comment.
I think we shouldn't depend on Silex\Application anymore. Note Silex\Application extends Pimple\Container.
We should remove this line and update any reference to ``Silex\Application`.
Also Pimple\ServiceProviderInterface doesn't define a boot() method. So should we also remove that method?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Silex 2 support so I can bump OpenCFP up to Silex 2 (now that it's officially out). Also added phpunit to the composer.json (just because that's my preferred way to invoke it - I can back that out if that would be better). This does break Silex 1.0 compatibility, so it would probably be a good idea to bump the tag to 2.0 once committed. Resolves issue #54