Update the Yaml driver #39
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As mentioned in the [symfony\yaml](symfony/yaml@a436568) "Passing a file as an input is a deprecated feature and will be removed in 3.0."
|
GG I was just getting ready to submit a pull request. The error message about the foreach loop didn't help much. Anyway, it seems Igor has abandoned the repository. :( |
|
@igorw please merge and tag this, without this fix, the provider does not run on symfony 2.7 components without deprecation messages |
|
+1 |
|
Igor, in his own words, is now a software philosopher. I suggest forking, patching and using your fork in your project. Hakuna Matata. |
|
i use my fork, i hope you will join, your PR is allready in an taged as v1.2.3 https://github.com/saxulum/ConfigServiceProvider |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in the symfony\yaml since 2.2:
"Passing a file as an input is a deprecated feature and will be removed in 3.0."