Support file extensions in uppercase #289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since version 1.3.1 (fa64570), the extension of an attachment is validated against its content type. However, when the extension is not in lowercase, validation fails. This commit fixes the issue by downcasing the attachment's extension before checking it against possible extensions for the content type.
Mth0158
requested changes
Nov 12, 2024
Addresses the following comment: igorkasyanchuk#289 (comment)
Mth0158
pushed a commit
that referenced
this pull request
Nov 24, 2024
Addresses the following comment: #289 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since version 1.3.1 (fa64570), the extension of an attachment is validated against its content type. However, when the extension is not in lowercase, validation fails.
This commit fixes the issue by downcasing the attachment's extension before checking it against possible extensions for the content type.