Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead code for Rails 5.x, 6.x, and < 6.1.4 #267

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

tagliala
Copy link
Contributor

@tagliala tagliala commented Oct 11, 2024

PR #256 updated the minimum required version of Rails subcomponents to
6.1.4.

However, it also included conditionals specific to version 6.1.4.

This code is unnecessary as the library does not support versions of
Rails below 6.1.4.


Please review with "hide whitespace" option enabled

image

@tagliala tagliala marked this pull request as ready for review October 11, 2024 08:44
@Mth0158
Copy link
Collaborator

Mth0158 commented Oct 13, 2024

Hi @tagliala (again!)
I am totally on for these changes, I wanted to do this in the coming days/weeks, @igorkasyanchuk are you ok to deprecate support for Rails 5.x, and Rails 6 < 6.1.4?
I think it could be in the same release as the #256 release. Unsure if it's better when we drop support for a major of Rails to make a major or minor release?

@tagliala
Copy link
Contributor Author

tagliala commented Oct 13, 2024

Hi,

are you ok to deprecate support for Rails 5.x, and Rails 6 < 6.1.4?

Rails < 6.1.4 support has been already removed in current main, in the meaning that current main will not be installed on < 6.1.4:

%w[activejob activemodel activestorage activesupport].each { |rails_subcomponent| s.add_dependency rails_subcomponent, '>= 6.1.4' }

The code removed here is just dead code, unless I'm missing something


edit

Probably the intent of #256 was different, because checks were introduced here, but the gem won't install on Rails < 6.1.4

@tagliala tagliala force-pushed the chore/remove-dead-code branch 3 times, most recently from 6e9020f to cb6d371 Compare October 13, 2024 19:05
PR igorkasyanchuk#256 updated the minimum required version of Rails subcomponents to
6.1.4.

However, it also included conditionals specific to version 6.1.4.

This code is unnecessary as the library does not support versions of
Rails below 6.1.4.
@tagliala tagliala changed the title Remove Rails 5.x, 6.x, and < 6.1.4 code Remove dead code for Rails 5.x, 6.x, and < 6.1.4 Oct 13, 2024
@Mth0158
Copy link
Collaborator

Mth0158 commented Oct 14, 2024

Probably the intent of #256 was different, because checks were introduced here, but the gem won't install on Rails < 6.1.4

Totally right, I shd have removed the dead code with this PR, let's remove it now that it's useless.

@Mth0158 Mth0158 merged commit dff85e4 into igorkasyanchuk:master Oct 14, 2024
20 checks passed
@tagliala tagliala deleted the chore/remove-dead-code branch October 14, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants