Skip to content

231 make sure a zero byte image is properly managed #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 11, 2023
Merged

231 make sure a zero byte image is properly managed #232

merged 3 commits into from
Dec 11, 2023

Conversation

Mth0158
Copy link
Collaborator

@Mth0158 Mth0158 commented Dec 8, 2023

No description provided.

@Mth0158 Mth0158 linked an issue Dec 8, 2023 that may be closed by this pull request
Make sure a zero byte image is properly managed #231
Closed
@Mth0158
Copy link
Collaborator Author

Mth0158 commented Dec 8, 2023

Okay so we cover well this case with MiniMagick but we fail with Vips, interesting

@Mth0158
Copy link
Collaborator Author

Mth0158 commented Dec 11, 2023 •
edited
Loading

Issue discussed at image_processing gem janko/image_processing#97.
It's an edge case that will always throw the VipsForeignLoad error, we should rescue this error and return false.

@Mth0158 Mth0158 merged commit aba146e into master Dec 11, 2023
@Mth0158 Mth0158 deleted the 231-make-sure-a-zero-byte-image-is-properly-managed branch December 11, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make sure a zero byte image is properly managed
1 participant
@Mth0158