Fix duplication of Info.plist copying that was causing Xcode errors #194
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under Xcode 9 new build system, the dependency tree checker is much more strict.
If an
Info.plist
appears both as the target's.plist
file, and in the build resource phase, Xcode will halt with an error similar to this:This PR aims to solve the issue by exempting a file if it's the target's
plist
file.I've added unit tests for the case, and, for the first time, an integration test that does the following:
.pbxproj
matches the fixture by usingXcodeproj::Differ.project_diff
xcodebuild
and makes sure it passesxcodebuild
output matches the fixture