feat: scaffold chain-registry files #4413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
component:ci
julienrbrt
requested review from
ilgooz,
salmad3,
toschdev,
jeronimoalbi and
Pantani
as code owners
salmad3
requested changes
Jan 11, 2025
| Use: "chain-registry", | ||
| Short: "Configs for the chain registry", | ||
| Long: `Scaffold the chain registry chain.json and assets.json files. | ||
|
|
There was a problem hiding this comment.
Should certain fields should be configurable?
For instance:
c.Flags().String("status", "upcoming", "Chain status (mainnet, testnet, upcoming, etc.)")
and then consumed in scaffoldChainRegistryFiles
status, _ := cmd.Flags().GetString("status")
And passed down to AddChainRegistryFiles
if err = sc.AddChainRegistryFiles(c, cfg, status); err != nil {
return err
}
``
There was a problem hiding this comment.
I wasn't super sure. As youd scaffold this when you need the frontend, and usually it is at devnet. Wanted to keep it KISS. But we can always add if you find it valuable.
salmad3
approved these changes
Jan 13, 2025
mergify bot
pushed a commit
that referenced
this pull request
Jan 13, 2025
* feat: scaffold chain-registry files * cl * cl * updates * updates * typo * renaming * finalize chain-registry * updates * lint * lint * typos (cherry picked from commit ed3d0b3)
julienrbrt
pushed a commit
that referenced
this pull request
Jan 13, 2025
This was referenced Jan 14, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a new command for scaffold chain-registry template files.
ignite s chain-registryIt will be useful for this: ignite/apps#140, in order to have the js wallet connect be able to easily add the chain.
Additionally, it is useful when a chain gets to testnet and launching phase, to have those files ready to publish on https://github.com/cosmos/chain-registry