Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: remove the ignite relayer and tools commands with all ts-relayer logic (backport #4076) #4226

Merged
merged 16 commits into from
Jul 15, 2024
Merged

feat!: remove the ignite relayer and tools commands with all ts-relayer logic (backport #4076) #4226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
3276327
feat!: remove the ignite `realyer` and `tools` commands with all ts-r…
Pantani May 5, 2024
fc77bab
fix merge conflicts
Pantani Jul 2, 2024
9c8b8e4
fix changelog
Pantani Jul 2, 2024
e4726ed
Merge remote-tracking branch 'origin/release/v28.x.y' into mergify/bp…
Pantani Jul 10, 2024
da03607
Merge remote-tracking branch 'origin/release/v28.x.y' into mergify/bp…
Pantani Jul 10, 2024
108f691
bump hermes version
Pantani Jul 10, 2024
aff22b8
bump hermes to future version for don't break the default plugin path
Pantani Jul 10, 2024
b0e91c4
remove unused commands
Pantani Jul 10, 2024
327cadc
rollback integration/plugin/testdata/example-plugin/go.mod
Pantani Jul 10, 2024
198f581
rollback ignite/internal/plugin/testdata
Pantani Jul 10, 2024
1c7cc8e
rollback integration/plugin/testdata/example-plugin/go.mod
Pantani Jul 10, 2024
24d6943
rollback hermes version for integration tests
Pantani Jul 10, 2024
f96425f
Merge branch 'release/v28.x.y' into mergify/bp/release/v28.x.y/pr-4076
julienrbrt Jul 10, 2024
5e1a5a8
remove default plugins
Pantani Jul 10, 2024
e7569a8
skip TestEnsureDefaultPlugins.
Pantani Jul 10, 2024
691491a
run make format
Pantani Jul 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
### Features

- [#4183](https://github.com/ignite/cli/pull/4183) Set `chain-id` in the client.toml
- [#4076](https://github.com/ignite/cli/pull/4076) Remove the ignite `relayer` and `tools` commands with all ts-relayer logic
- [#4133](https://github.com/ignite/cli/pull/4133) Improve buf rate limit

### Changes
Expand Down
6 changes: 0 additions & 6 deletions ignite/cmd/cmd.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,6 @@ To get started, create a blockchain:
NewGenerate(),
NewNode(),
NewAccount(),
NewRelayer(),
NewTools(),
NewDocs(),
NewVersion(),
NewApp(),
Expand Down Expand Up @@ -207,10 +205,6 @@ func checkNewVersion(ctx context.Context) {
fmt.Printf("⬆️ Ignite CLI %s is available! To upgrade: https://docs.ignite.com/welcome/install#upgrade", next)
}

func printSection(session *cliui.Session, title string) error {
return session.Printf("------\n%s\n------\n\n", title)
}

func newCache(cmd *cobra.Command) (cache.Storage, error) {
cacheRootDir, err := config.DirPath()
if err != nil {
Expand Down
24 changes: 17 additions & 7 deletions ignite/cmd/plugin_default.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,21 +18,31 @@ type defaultPlugin struct {
const (
PluginNetworkVersion = "v0.2.2"
PluginNetworkPath = "github.com/ignite/cli-plugin-network@" + PluginNetworkVersion
PluginRelayerVersion = "hermes/v0.2.4"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that version doesn't exist yet. Shall we use a commit for now?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may want ignite/apps#111 before tagging v0.2.4 and it needs v28.4.1 beforehand to be able to do so.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to release the version hermes/v0.2.4 based on ignite/apps#111 because we need to remove the relayer command from CLI and use it inside the Hermes app. If not the app will break

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I think I will remove the default apps now since the network is not working and the hermes needs the cycle dependency

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think, so there will be like only 10 min where it won't work I guess. Makes sense.

PluginRelayerPath = "github.com/ignite/apps/hermes@" + PluginRelayerVersion
)

// defaultPlugins holds the plugin that are considered trustable and for which
// a command will added if the plugin is not already installed.
// When the user executes that command, the plugin is automatically installed.
var defaultPlugins = []defaultPlugin{
{
use: "network",
short: "Launch a blockchain in production",
aliases: []string{"n"},
path: PluginNetworkPath,
},
// TODO uncomment after fix SPN. Don't forget to un-skip TestEnsureDefaultPlugins.
// {
// use: "network",
// short: "Launch a blockchain in production",
// aliases: []string{"n"},
// path: PluginNetworkPath,
// },
// TODO uncomment after launch the `hermes/v0.2.4`. Don't forget to un-skip TestEnsureDefaultPlugins.
// {
// use: "relayer",
// short: "Connect blockchains with an IBC relayer",
// aliases: []string{"r"},
// path: PluginRelayerPath,
// },
}

// ensureDefaultPlugins ensures that all defaultPlugins are wether registered
// ensureDefaultPlugins ensures that all defaultPlugins are whether registered
// in cfg OR have an install command added to rootCmd.
func ensureDefaultPlugins(rootCmd *cobra.Command, cfg *pluginsconfig.Config) {
for _, dp := range defaultPlugins {
Expand Down
2 changes: 2 additions & 0 deletions ignite/cmd/plugin_default_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@ import (
)

func TestEnsureDefaultPlugins(t *testing.T) {
t.Skip("skip till we have default plugins again")

tests := []struct {
name string
cfg *pluginsconfig.Config
Expand Down
33 changes: 0 additions & 33 deletions ignite/cmd/relayer.go
View file
Open in desktop

This file was deleted.

Loading
Loading