forked from PaperMC/Paper
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pull] master from PaperMC:master #907
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes spurious build failures from OOM
Upstream has released updates that appear to apply and compile correctly. This update has not been tested by PaperMC and as with ANY update, please do your own testing CraftBukkit Changes: c294e05d7 SPIGOT-7975: Fix issue with Pale Sapling growing c9f5a8fdf SPIGOT-7974: Fix Crash for Creaking Heart Block particle
VoxelShape coordiantes generally are an integer + a sum of powers of two between [-1, -3]. Most offsets are generally an integer. As a result, applying an offset to the coordinates generally results in an error of 0. However, coordinate inputs do not follow such trends. Thus, when applying an offset to the coordinate input, there may be some floating point error. By applying the offset to the VoxelShape coordinates, we can eliminate additional floating point error. This change also fixes the inconsistency when using the single AABB, as input coordinates were not offset when using the single AABB as the single AABB is already offset. Fixes Tuinity/Moonrise#81 This specific issue is caused by floating point error resulting in the falling anvil's y position becoming around -8E-17 when it should be 0. While this is still very comfortably in the collision epsilon (1.0E-7), this results in the falling anvil's y block position to become -1 (as the block position is simply the floor of the coordinate).
setup-gradle v4 validates the wrapper
This prevent the creaking from being pushed with knockback enchant when it can't move
…e/runtime classpath (#11712)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )