Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement Display for Partition, Segment and Stream #488

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

implement Display for Partition, Segment and Stream #488

wants to merge 1 commit into from

Conversation

berendsliedrecht
Copy link
Contributor

hubcio
hubcio requested changes Jan 7, 2024
View reviewed changes
server/src/streaming/partitions/messages.rs Outdated
continue;
}

let time_indexes = segment.time_indexes.as_ref().unwrap();
let time_indexes = segment.time_indices.as_ref().unwrap();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let time_indices

@hubcio
Copy link
Collaborator

hubcio commented Jan 7, 2024

@berendsliedrecht please take a look at discord 🦀

@hubcio
Copy link
Collaborator

hubcio commented Jan 7, 2024 •
edited

image

Just to add, if the PR would get too big, split it into separate PRs for Partition, Segment, etc.

@hubcio
Copy link
Collaborator

hubcio commented Jan 12, 2024

hey @berendsliedrecht, any plans to continue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hubcio hubcio hubcio requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

impl Display for Partition, Segment, Stream
2 participants
@berendsliedrecht @hubcio