Add a couple of features #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the remote raises an error like 400 Bad Request, the error is generally lost, and all you see is "HTTPError()". Interpret the error document in the response and raise a better exception in lieu of more formal exception decoding.
A couple of API functions were missed; add hooks to create binding functions.
| try: | ||
| res = urlopen(req) | ||
| except HTTPError, e: | ||
| resp = "".join(e.readlines()) |
There was a problem hiding this comment.
any reason not to use resp = e.read() ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there, I worked on a standup bot, and I needed these two changes for it to work correctly. More detailed descriptions are on individual commits. Cheers and thanks for writing this module!